fix sloppy if conditions

Author: joonlabs

src/Execution/Executor.php

@@ -127,8 +127,8 @@ public function collectFields(ExecutionContext $executionContext, GraphQLObjectT
                         break;
                     }
                     $visitedFragmentNames[$fragName] = true;
-                    $fragment = $executionContext->getFragments()[$fragName];
-                    if (!$fragment || !$this->doesFragmentConditionMatch($executionContext, $fragment, $runtimeType)) {
+                    $fragment = $executionContext->getFragments()[$fragName] ?? null;
+                    if ($fragment === null || !$this->doesFragmentConditionMatch($executionContext, $fragment, $runtimeType)) {
                         break;
                     }
                     $this->collectFields(
@@ -166,8 +166,8 @@ private function getFieldEntryKey($node): string
      */
     private function doesFragmentConditionMatch(ExecutionContext $executionContext, $fragment, GraphQLObjectType $type): bool
     {
-        $typeConditionNode = $fragment["typeCondition"];
-        if (!$typeConditionNode) {
+        $typeConditionNode = $fragment["typeCondition"] ?? null;
+        if ($typeConditionNode === null) {
             return true;
         }
 

src/Execution/Values.php

@@ -12,6 +12,12 @@
 
 abstract class Values
 {
+    /**
+     * @param Schema $schema
+     * @param array $variableDefinitions
+     * @param array $inputs
+     * @return array
+     */
     public static function getVariableValues(Schema $schema, array $variableDefinitions, array $inputs): array
     {
         $errors = [];
@@ -23,6 +29,14 @@ public static function getVariableValues(Schema $schema, array $variableDefiniti
         return $errors;
     }
 
+    /**
+     * @param Schema $schema
+     * @param array $variableDefinitions
+     * @param array $inputs
+     * @return array
+     * @throws GraphQLError
+     * @throws \GraphQL\Errors\ValidationError
+     */
     public static function coerceVariableValues(Schema $schema, array $variableDefinitions, array $inputs): array
     {
         $coercedValues = [];
@@ -69,6 +83,13 @@ public static function coerceVariableValues(Schema $schema, array $variableDefin
         return $coercedValues;
     }
 
+    /**
+     * @param GraphQLDirective $directiveDef
+     * @param $node
+     * @param $variableValues
+     * @return array|null
+     * @throws GraphQLError
+     */
     public static function getDirectiveValues(GraphQLDirective $directiveDef, $node, $variableValues): ?array
     {
         $directiveNode = array_filter($node["directives"], function ($directive) use ($directiveDef) {
@@ -83,6 +104,14 @@ public static function getDirectiveValues(GraphQLDirective $directiveDef, $node,
         return null;
     }
 
+    /**
+     * @param $def
+     * @param $node
+     * @param $variableValues
+     * @return array
+     * @throws GraphQLError
+     * @throws \GraphQL\Errors\ValidationError
+     */
     public static function getArgumentValues($def, $node, $variableValues): array
     {
         $coercedValues = [];
@@ -99,7 +128,7 @@ public static function getArgumentValues($def, $node, $variableValues): array
             $argumentNode = $argNodeMap[$name] ?? null;
 
             // if no argument specified in AST, check if default argument exists and is valid
-            if (!$argumentNode) {
+            if ($argumentNode === null) {
                 if ($argDef->getDefaultValue() !== null) {
                     $coercedValues[$name] = $argDef->getDefaultValue();
                 } else if ($argType->isNonNullType()) {

src/Utilities/Ast.php

@@ -12,6 +12,12 @@
 
 abstract class Ast
 {
+    /**
+     * @param Schema $schema
+     * @param $typeNode
+     * @return GraphQLList|GraphQLNonNull|GraphQLType|null
+     * @throws GraphQLError
+     */
     static function typeFromAst(Schema $schema, $typeNode)
     {
         if ($typeNode["kind"] === "ListType") {
@@ -31,9 +37,16 @@ static function typeFromAst(Schema $schema, $typeNode)
         );
     }
 
-    static function valueFromAst(array $valueNode, GraphQLType $type, ?array $variables = null)
+    /**
+     * @param array|null $valueNode
+     * @param GraphQLType $type
+     * @param array|null $variables
+     * @return array|UndefinedValue|mixed|null
+     * @throws ValidationError
+     */
+    static function valueFromAst(?array $valueNode, GraphQLType $type, ?array $variables = null)
     {
-        if (!$valueNode) {
+        if ($valueNode === null) {
             // When there is no node, then there is also no value.
             // Importantly, this is different from returning the value null.
             return new UndefinedValue();
@@ -182,6 +195,11 @@ static function valueFromAst(array $valueNode, GraphQLType $type, ?array $variab
         return new UndefinedValue();
     }
 
+    /**
+     * @param $valueNode
+     * @param $variables
+     * @return bool
+     */
     private static function isMissingVariable($valueNode, $variables): bool
     {
         return (