Add phpstan baseline for 3.x-dev and fix errors

Author: richard67

phpstan-baseline.neon

@@ -0,0 +1,40 @@
+parameters:
+	excludePaths:
+		analyse:
+			-	src/phputf8/*
+	ignoreErrors:
+		-
+			message: "#^Call to deprecated method rules\\(\\) of class Doctrine\\\\Common\\\\Inflector\\\\Inflector\\.$#"
+			count: 1
+			path: src/Inflector.php
+
+		-
+			message: """
+				#^Call to deprecated method toPlural\\(\\) of class Joomla\\\\String\\\\Inflector\\:
+				3\\.0  Use Doctrine\\\\Common\\\\Inflector\\\\Inflector\\:\\:pluralize\\(\\) instead\\.$#
+			"""
+			count: 1
+			path: src/Inflector.php
+
+		-
+			message: """
+				#^Call to deprecated method toSingular\\(\\) of class Joomla\\\\String\\\\Inflector\\:
+				3\\.0  Use Doctrine\\\\Common\\\\Inflector\\\\Inflector\\:\\:singularize\\(\\) instead\\.$#
+			"""
+			count: 2
+			path: src/Inflector.php
+
+		-
+			message: "#^Class Joomla\\\\String\\\\Inflector extends deprecated class Doctrine\\\\Common\\\\Inflector\\\\Inflector\\.$#"
+			count: 1
+			path: src/Inflector.php
+
+		-
+			message: "#^Method Joomla\\\\String\\\\Inflector\\:\\:getInstance\\(\\) should return static\\(Joomla\\\\String\\\\Inflector\\) but returns Joomla\\\\String\\\\Inflector\\.$#"
+			count: 1
+			path: src/Inflector.php
+
+		-
+			message: "#^Unsafe usage of new static\\(\\)\\.$#"
+			count: 2
+			path: src/Inflector.php

phpstan.neon

@@ -1,6 +1,7 @@
 
 includes:
 	- vendor/phpstan/phpstan-deprecation-rules/rules.neon
+	- phpstan-baseline.neon
 
 parameters:
 	level: 5

src/StringHelper.php

@@ -74,7 +74,7 @@ public static function increment($string, $style = 'default', $n = 0)
 
         // Check if we are incrementing an existing pattern, or appending a new one.
         if (preg_match($rxSearch, $string, $matches)) {
-            $n      = empty($n) ? ($matches[1] + 1) : $n;
+            $n      = empty($n) ? (1 + (int) $matches[1]) : $n;
             $string = preg_replace($rxReplace, sprintf($oldFormat, $n), $string);
         } else {
             $n = empty($n) ? 2 : $n;
@@ -338,7 +338,7 @@ public static function strcasecmp($str1, $str2, $locale = false)
         }
 
         // Get current locale
-        $locale0 = setlocale(LC_COLLATE, 0);
+        $locale0 = setlocale(LC_COLLATE, '0');
 
         if (!$locale = setlocale(LC_COLLATE, $locale)) {
             $locale = $locale0;
@@ -384,7 +384,7 @@ public static function strcmp($str1, $str2, $locale = false)
     {
         if ($locale) {
             // Get current locale
-            $locale0 = setlocale(LC_COLLATE, 0);
+            $locale0 = setlocale(LC_COLLATE, '0');
 
             if (!$locale = setlocale(LC_COLLATE, $locale)) {
                 $locale = $locale0;

src/phputf8/stristr.php

@@ -11,7 +11,7 @@
 * Note: requires utf8_strtolower
 * @param string
 * @param string
-* @return int
+* @return string|boolean
 * @see http://www.php.net/strcasecmp
 * @see utf8_strtolower
 * @package utf8