Skip to content

Commit bc86e10

Browse files
authored
Remove Channels 2.4 in CI (#134)
Channels 2.4 is proving problematic in CI, and it's not worth the effort to maintain that. Sockpuppet should still work for channels 2.4, but given we don't run a CI for it we can't make any promises for it.
1 parent 52e3209 commit bc86e10

File tree

2 files changed

+2
-26
lines changed

2 files changed

+2
-26
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ jobs:
6868
runs-on: ubuntu-latest
6969
strategy:
7070
matrix:
71-
channels: ["2.4", "3.0"]
71+
channels: ["3.0"]
7272

7373
steps:
7474
- uses: actions/checkout@v2

tox.ini

Lines changed: 1 addition & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -25,30 +25,6 @@ basepython =
2525
py3.7: python3.7
2626
py3.6: python3.6
2727

28-
[testenv:py3.9-django3.2-channels2.4-cypress]
29-
setenv =
30-
PYTHONPATH = {toxinidir}:{toxinidir}/sockpuppet
31-
whitelist_externals =
32-
sh
33-
npm
34-
inv
35-
commands =
36-
sh -c "pwd"
37-
inv integration
38-
sh -c "coverage run manage.py testserver cypress/fixtures/user.json --noinput &"
39-
npm run cypress:run
40-
sh -c "echo $(ps | grep coverage | grep -v grep | awk '\{print $1\}')"
41-
sh -c "kill -s HUP $(ps | grep coverage | grep -v grep | awk '\{print $1\}')"
42-
codecov -e TOXENV
43-
44-
deps =
45-
django3.1: Django>=3.2,<3.3
46-
channels2.4: channels<3.0
47-
-r{toxinidir}/requirements_test.txt
48-
49-
basepython =
50-
py3.9: python3.9
51-
5228
[testenv:py3.9-django3.2-channels3.0-cypress]
5329
setenv =
5430
PYTHONPATH = {toxinidir}:{toxinidir}/sockpuppet
@@ -66,7 +42,7 @@ commands =
6642
codecov -e TOXENV
6743

6844
deps =
69-
django3.1: Django>=3.2,<3.3
45+
django3.2: Django>=3.2,<3.3
7046
channels3.0: channels>=3.0,<3.1
7147
-r{toxinidir}/requirements_test.txt
7248

0 commit comments

Comments
 (0)