Fixes to SocketpuppetConsumer for handling dotfiles

    1. Update requirements_dev.txt to include base requirements, as
       these are necessary for starting the server and performing any tests.

    2. Use Reflex.__subclasses__() rather than name checking for reflex
       subclass detection, which will be more consistent and allow users
       to name their reflexes whatever they want.

    3. Clear falsey values from the filepaths detected in the
       load_reflexes_from_config function, which is a tenuous solution to
       not including vim-generated dotfiles in the module loading process.

undo style changes

Author: mekhami

requirements_dev.txt

@@ -1,4 +1,5 @@
 -r requirements_test.txt
+-r requirements.txt
 
 django-extensions
 invoke

sockpuppet/consumer.py

@@ -16,7 +16,7 @@
 from django.conf import settings
 
 from .channel import Channel
-from .reflex import PROTECTED_VARIABLES
+from .reflex import PROTECTED_VARIABLES, Reflex
 from .element import Element
 from .utils import classify
 
@@ -109,34 +109,36 @@ def group_send(self, recipient, message):
         send(recipient, message)
 
     def load_reflexes_from_config(self, config):
-        def append_reflex(module):
-            # TODO only import classes that are actually that inherits Reflex
-            for classname in dir(module):
-                if 'reflex' in classname.lower():
-                    ReflexClass = getattr(module, classname)
-                    self.reflexes[ReflexClass.__name__] = ReflexClass
+        def append_reflex():
+            self.reflexes.update(
+                {
+                    ReflexClass.__name__: ReflexClass
+                    for ReflexClass in Reflex.__subclasses__()
+                }
+            )
 
         modpath = config.module.__path__[0]
 
         for dirpath, dirnames, filenames in walk(modpath):
             if dirpath == modpath and 'reflexes.py' in filenames:
                 # classes in reflexes.py
                 import_path = '{}.reflexes'.format(config.name)
-                module = import_module(import_path)
+                import_module(import_path)
+                append_reflex()
 
-                append_reflex(module)
             elif dirpath == path.join(modpath, 'reflexes'):
                 # assumes reflexes folder is placed directly in app.
                 import_path = '{config_name}.reflexes.{reflex_file}'
 
                 for filename in filenames:
-                    name = filename.split('.')[0]
+                    # eliminates empty values in the filename before getting the
+                    # module name from the filename.
+                    name = [file for file in filename.split('.') if file][0]
                     full_import_path = import_path.format(
                         config_name=config.name, reflex_file=name
                     )
-                    module = import_module(full_import_path)
-
-                    append_reflex(module)
+                    import_module(full_import_path)
+                    append_reflex()
 
     def reflex_message(self, data, **kwargs):
         logger.debug('Json: %s', data)