Use docker/login-action to do the GHCR login

Author: jonashackt

.github/workflows/publish.yml

@@ -9,9 +9,15 @@ jobs:
     steps:
     - uses: actions/checkout@v2
 
+    - name: Login to GitHub Container Registry
+      uses: docker/login-action@v1
+      with:
+        registry: ghcr.io
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
+
     - name: Build the hello-world Docker image
       run: |
-        echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u jonashackt --password-stdin
         docker build . --tag ghcr.io/jonashackt/hello-world:latest
         docker run ghcr.io/jonashackt/hello-world:latest
         docker push ghcr.io/jonashackt/hello-world:latest

README.md

@@ -132,10 +132,22 @@ jobs:
 
     - name: Build the hello-world Docker image
       run: |
-        echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u jonashackt --password-stdin
+        echo ${{ secrets.GITHUB_TOKEN }} | docker login ghcr.io -u ${{ github.actor }} --password-stdin
 
 ```
 
+or Alternatively we can also use the [docker/login-action](https://github.com/docker/login-action) to to the login:
+
+```yaml
+    - name: Login to GitHub Container Registry
+      uses: docker/login-action@v1
+      with:
+        registry: ghcr.io
+        username: ${{ github.actor }}
+        password: ${{ secrets.GITHUB_TOKEN }}
+```
+
+
 #### Publish (Push) Container image to GHCR
 
 The final step now is to push our container image to the GitHub Container Registry. Therefore we need to tag our image correctly while building it using `ghcr.io/OWNER/IMAGE_NAME:latest`. After that we can push it: