Merge pull request #358 from ISnowFoxI/fix/integer-overflow

Fixed integer overflow issue in slice function for android

Author: RonRadtke

android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilFS.java

@@ -678,7 +678,7 @@ static void ls(String path, Promise promise) {
      * @param end    End byte offset
      * @param encode NOT IMPLEMENTED
      */
-    static void slice(String path, String dest, int start, int end, String encode, Promise promise) {
+    static void slice(String path, String dest, long start, long end, String encode, Promise promise) {
         try {
             dest = ReactNativeBlobUtilUtils.normalizePath(dest);
 
@@ -696,13 +696,13 @@ static void slice(String path, String dest, int start, int end, String encode, P
                 return;
             }
             FileOutputStream out = new FileOutputStream(new File(dest));
-            int skipped = (int) in.skip(start);
+            long skipped = in.skip(start);
             if (skipped != start) {
                 promise.reject("EUNSPECIFIED", "Skipped " + skipped + " instead of the specified " + start + " bytes");
                 return;
             }
             byte[] buffer = new byte[10240];
-            int remain = end - start;
+            int remain = (int) (end - start);
             while (remain > 0) {
                 int read = in.read(buffer, 0, 10240);
                 if (read <= 0) {

android/src/main/java/com/ReactNativeBlobUtil/ReactNativeBlobUtilImpl.java

@@ -294,7 +294,7 @@ public void cancelRequest(String taskId, Callback callback) {
         }
     }
 
-    public void slice(String src, String dest, int start, int end, Promise promise) {
+    public void slice(String src, String dest, long start, long end, Promise promise) {
         ReactNativeBlobUtilFS.slice(src, dest, start, end, "", promise);
     }
 

android/src/newarch/java/com/ReactNativeBlobUtil/ReactNativeBlobUtil.java

@@ -198,7 +198,7 @@ public void enableUploadProgressReport(String taskId, double interval, double co
 
     @Override
     public void slice(String src, String dest, double start, double end, Promise promise) {
-       delegate.slice(src, dest, (int) start, (int) end, promise);
+       delegate.slice(src, dest, (long) start, (long) end, promise);
     }
 
     @Override

android/src/oldarch/java/com/ReactNativeBlobUtil/ReactNativeBlobUtil.java

@@ -174,8 +174,8 @@ public void cancelRequest(String taskId, Callback callback) {
     }
 
     @ReactMethod
-    public void slice(String src, String dest, int start, int end, Promise promise) {
-        delegate.slice(src, dest, start, end, promise);
+    public void slice(String src, String dest, double start, double end, Promise promise) {
+        delegate.slice(src, dest, (long) start, (long) end, promise);
     }
 
     @ReactMethod