Add ability to gracefully shut down the mjpeg server from other node processes or command line #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix cmd parameters to be unique
…9999 eventually stops.
Owner
|
Sorry for the delay reviewing this. Please can you update the readme to reflect the new options and defaults? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a process manager such as PM2 or embedding the MJPEG server inside another app, the app currently will not shut down correctly and sometimes leaves a process bound to your http server port or it leaves the camera image capture process running. Thus preventing PM2 or your app to start up again.
This change adds the ability to close the camera image capture and the http server gracefully and not leave any used ports when it's shut down or closed. This allows PM2 to re-start the app and recover from any unhanded error.
I have also fixed a bug on the command line parameters where the -s was specified multiple times.