Add bad-request-pred function again

Author: Ulf Gitschthaler

src/clj_http_hystrix/core.clj

@@ -43,7 +43,8 @@
    :hystrix/timeout-ms              1000
    :hystrix/breaker-request-volume  20
    :hystrix/breaker-error-percent   50
-   :hystrix/breaker-sleep-window-ms 5000})
+   :hystrix/breaker-sleep-window-ms 5000
+   :hystrix/bad-request-pred        client-error?})
 
 (def ^:private hystrix-keys
   (keys hystrix-base-configuration))
@@ -108,10 +109,11 @@
     (fn [f req]
       (if (not-empty (select-keys req hystrix-keys))
         (let [req (merge defaults req)
+              bad-request-pred (:hystrix/bad-request-pred req)
               fallback (:hystrix/fallback-fn req)
               wrap-exception-response (fn [resp]
                                         ((http/wrap-exceptions (constantly resp))
-                                         (assoc req :throw-exceptions (not (client-error? req resp)))))
+                                         (assoc req :throw-exceptions (not (bad-request-pred req resp)))))
               configurator (configurator req)
               logging-context (or (MDC/getCopyOfContextMap) {})
               command (proxy [HystrixCommand] [configurator]

test/clj_http_hystrix/core_test.clj

@@ -113,7 +113,7 @@
                                           :throw-exceptions false})]
          (:status response) => 503)))
 
-(fact "errors will not cause circuit to break if client-error? is true, with :throw-exceptions false"
+(fact "errors will not cause circuit to break if bad-request-pred is true, with :throw-exceptions false"
       (rest-driven
        [{:method :GET
          :url "/"}
@@ -130,7 +130,7 @@
          (http/get url {:throw-exceptions false
                         :hystrix/command-key command-key}) => (contains {:status 200}))))
 
-(fact "errors will not cause circuit to break if client-error? is true, with :throw-exceptions true"
+(fact "errors will not cause circuit to break if bad-request-pred is true, with :throw-exceptions true"
       (rest-driven
        [{:method :GET
          :url "/"}