Merge pull request #48 from ondergetekende/unit-tests

Add unit tests

Author: kvdveer

.gitignore

@@ -8,3 +8,5 @@
 /django_bootstrap_pagination.egg-info
 /dist
 /build
+/htmlcov
+.coverage

.travis.yml

@@ -0,0 +1,67 @@
+language: python
+python:
+  - "2.6"
+  - "2.7"
+  # - "3.2"  Has been dropped by many dependencies
+  - "3.3"
+  - "3.4"
+  - "3.5"
+#  - "nightly"  Fails irregularly
+#  - "pypy"  # Can't install lxml
+#  - "pypy3" # Can't install lxml
+env:
+  matrix:
+   - DJANGO="Django<1.3"
+   - DJANGO="Django<1.4"
+   - DJANGO="Django<1.5"
+   - DJANGO="Django<1.6"
+   - DJANGO="Django<1.7"
+   - DJANGO="Django<1.8"
+   - DJANGO="Django<1.9"
+   - DJANGO="Django<1.10"
+install:
+# pip >=8 dropped Python 3.2 support
+- pip install "pip<8.0.0" wheel
+- pip install "$DJANGO"
+- pip install -r test-requirements.txt
+cache:
+  directories:
+    - $HOME/.cache/pip
+matrix:
+  exclude:
+    # Python 3.5 is supported as of django 1.8
+    - {python: "3.5", env: DJANGO="Django<1.3"}
+    - {python: "3.5", env: DJANGO="Django<1.4"}
+    - {python: "3.5", env: DJANGO="Django<1.5"}
+    - {python: "3.5", env: DJANGO="Django<1.6"}
+    - {python: "3.5", env: DJANGO="Django<1.7"}
+    - {python: "3.5", env: DJANGO="Django<1.8"}
+
+    # Python 3.4 is supported as of django 1.5
+    - {python: "3.4", env: DJANGO="Django<1.3"}
+    - {python: "3.4", env: DJANGO="Django<1.4"}
+    - {python: "3.4", env: DJANGO="Django<1.5"}
+    - {python: "3.4", env: DJANGO="Django<1.6"}
+
+    # Python 3.3 is supported as of django 1.5, but dropped by 1.9+
+    - {python: "3.3", env: DJANGO="Django<1.3"}
+    - {python: "3.3", env: DJANGO="Django<1.4"}
+    - {python: "3.3", env: DJANGO="Django<1.5"}
+    - {python: "3.3", env: DJANGO="Django<1.6"}
+    - {python: "3.3", env: DJANGO="Django<1.10"}
+
+    # Python 3.2 is supported as of django 1.5, but dropped by 1.9+
+    - {python: "3.2", env: DJANGO="Django<1.3"}
+    - {python: "3.2", env: DJANGO="Django<1.4"}
+    - {python: "3.2", env: DJANGO="Django<1.5"}
+    - {python: "3.2", env: DJANGO="Django<1.6"}
+    - {python: "3.2", env: DJANGO="Django<1.10"}
+
+    # Python 2.6 is supported up until django 1.7
+    - {python: "2.6", env: DJANGO="Django<1.8"}
+    - {python: "2.6", env: DJANGO="Django<1.9"}
+    - {python: "2.6", env: DJANGO="Django<1.10"}
+
+script: coverage run --source bootstrap_pagination ./run_tests.py 
+after_success:
+- coverage report --fail-under=80

README.md

@@ -1,6 +1,9 @@
 [![Stories in Ready](https://badge.waffle.io/jmcclell/django-bootstrap-pagination.png?label=ready)](https://waffle.io/jmcclell/django-bootstrap-pagination)
 [![PyPi version](https://pypip.in/v/django-bootstrap-pagination/badge.png)](https://crate.io/packages/django-bootstrap-pagination/)
 [![PyPi downloads](https://pypip.in/d/django-bootstrap-pagination/badge.png)](https://crate.io/packages/django-bootstrap-pagination/)
+[![Build Status](https://travis-ci.org/jmcclell/django-bootstrap-pagination.png?branch=master)](https://travis-ci.org/ondergetekende/django-bootstrap-pagination)
+
+
 ## Django Bootstrap Pagination
 
 **Note:** This version is compatible with Bootstrap 3.x only! Please use the 1.0.x branch for Bootstrap 2 support.
@@ -10,17 +13,7 @@ work seamlessly with Django Page objects. By passing in a Page object and
 one or more optional arguments, Bootstrap pagination bars and pagers can
 be rendered with very little effort.
 
-Compatible with Django **1.3+**
-
-### Looking for collaborator(s)
-
-I have not had as much time as I would like to maintain this project. Since it is being used by quite a few, I would love to have someone help out as an additional maintainer. If anyone is interested, shoot me a note.
-
-High priority tasks:
-
-- [ ] Full testing suite
-- [ ] TravisCI setup to run said tests for each PR (all supported versions of Python and Django)
-- [ ] Python 3 support (maintaing backwards compatibility if possible, not required)
+Compatible with Django **1.2+**
 
 ## Installation
 

requirements.txt

@@ -0,0 +1 @@
+django>=1.2

run_tests.py

@@ -0,0 +1,25 @@
+#!/usr/bin/env python
+import os
+import unittest2
+
+import django
+
+
+def runtests():
+    os.environ['DJANGO_SETTINGS_MODULE'] = 'tests.test_settings'
+
+    try:
+        django.setup()
+    except AttributeError:  # Happens before django 1.7
+        pass
+
+    loader = unittest2.TestLoader()
+    tests = loader.discover('tests')
+    testRunner = unittest2.runner.TextTestRunner()
+    result = testRunner.run(tests)
+    if result.errors or result.failures:
+        exit(1)
+
+
+if __name__ == "__main__":
+    runtests()

test-requirements.txt

@@ -0,0 +1,5 @@
+mock
+lxml
+cssselect
+coverage
+unittest2

tests/__init__.py

@@ -0,0 +1,82 @@
+import django.conf
+import django.core.urlresolvers
+import django.http
+
+import mock
+import unittest2 as unittest
+
+from bootstrap_pagination.templatetags import bootstrap_pagination
+
+
+class TestHelpers(unittest.TestCase):
+    def test_strToBool(self):
+        self.assertTrue(bootstrap_pagination.strToBool('true'))
+        self.assertFalse(bootstrap_pagination.strToBool('false'))
+
+    @mock.patch('bootstrap_pagination.templatetags.bootstrap_pagination.'
+                'reverse')
+    def test_get_page_url_view(self, mock_reverse):
+        mock_reverse.return_value = "/some_nice_url"
+        url = bootstrap_pagination.get_page_url(
+            page_num=42,
+            current_app='the_current_app',
+            url_view_name='the_view',
+            url_extra_args=["arg1"],
+            url_extra_kwargs={"kwarg": "yes"},
+            url_param_name='page',
+            url_get_params=[],
+            url_anchor="derp")
+
+        self.assertEqual(url, '/some_nice_url#derp')
+        mock_reverse.assert_called_once_with('the_view',
+                                             args=['arg1'],
+                                             current_app='the_current_app',
+                                             kwargs={'kwarg': 'yes',
+                                                     'page': 42})
+
+    @mock.patch('bootstrap_pagination.templatetags.bootstrap_pagination.'
+                'reverse')
+    def test_get_page_url_view_sub(self, mock_reverse):
+        mock_reverse.side_effect = [
+            django.core.urlresolvers.NoReverseMatch(),
+            "/some_nice_url"
+        ]
+        url = bootstrap_pagination.get_page_url(
+            page_num=42,
+            current_app='the_current_app',
+            url_view_name='the_view',
+            url_extra_args=["arg1"],
+            url_extra_kwargs={"kwarg": "yes"},
+            url_param_name='page',
+            url_get_params=django.http.QueryDict(""),
+            url_anchor="derp")
+
+        self.assertEqual(url, '/some_nice_url#derp')
+        mock_reverse.assert_called_with('tests.the_view',
+                                        args=['arg1'],
+                                        current_app='the_current_app',
+                                        kwargs={'kwarg': 'yes',
+                                                'page': 42})
+
+    @mock.patch('bootstrap_pagination.templatetags.bootstrap_pagination.'
+                'reverse')
+    def test_get_page_url_straight(self, mock_reverse):
+        mock_reverse.return_value = "/some_nice_url"
+        url = bootstrap_pagination.get_page_url(
+            page_num=42,
+            current_app='the_current_app',
+            url_view_name=None,
+            url_extra_args=["arg1"],
+            url_extra_kwargs={"kwarg": "yes"},
+            url_param_name='page',
+            url_get_params=django.http.QueryDict("arg2=val"),
+            url_anchor="derp")
+
+        self.assertIn("arg2=val", url)
+        self.assertIn("page=42", url)
+        self.assertTrue(url.endswith("#derp"))
+
+
+if __name__ == '__main__':
+    django.conf.settings.configure()
+    unittest.main()

tests/test_helpers.py

@@ -0,0 +1,31 @@
+import unittest2 as unittest
+
+import lxml.html
+
+try:
+    from django.template.loader import get_template_from_string
+except ImportError:
+    from django.template import Engine
+    get_template_from_string = Engine.get_default().from_string
+
+from django.template import Context
+import django.http
+from django.core.paginator import Paginator
+
+
+class PagerTestCase(unittest.TestCase):
+    def test_example(self):
+        template = get_template_from_string("""
+            {% load bootstrap_pagination %}
+            {% bootstrap_pager page_obj %}
+        """)
+
+        objects = ["obj%02x" % idx
+                   for idx in range(30)]
+
+        paginator = Paginator(objects, 10)
+
+        c = Context({'page_obj': paginator.page(2),
+                     'request': django.http.HttpRequest()})
+        html = lxml.html.fragment_fromstring(template.render(c))
+        self.assertEqual(html.get('class'), 'pager')

tests/test_pager.py

@@ -0,0 +1,34 @@
+import unittest2 as unittest
+
+import lxml.html
+
+try:
+    from django.template.loader import get_template_from_string
+except ImportError:
+    from django.template import Engine
+    get_template_from_string = Engine.get_default().from_string
+
+from django.template import Context
+import django.http
+from django.core.paginator import Paginator
+
+
+class PaginateTestCase(unittest.TestCase):
+    def test_example(self):
+        template = get_template_from_string("""
+            {% load bootstrap_pagination %}
+            {% bootstrap_paginate page_obj range=10 %}
+        """)
+
+        objects = ["obj%02x" % idx
+                   for idx in range(30)]
+
+        paginator = Paginator(objects, 10)
+
+        c = Context({'page_obj': paginator.page(2),
+                     'request': django.http.HttpRequest()})
+        html = lxml.html.fragment_fromstring(template.render(c))
+        self.assertEqual(html.get('class'), 'pagination')
+        self.assertEqual(
+            html.cssselect('a[title=\"Current Page\"]')[0].text.strip(),
+                         '2')