Rollup merge of rust-lang#98205 - JohnTitor:remove-unnecessary-let, r=jyn514

JohnTitor · web-flow · commit f514aa4c077c · 2022-06-18T10:03:26.000+09:00
Remove a possible unnecessary assignment

The reference issue has been closed (the feature has been stabilized)
and things work fine without it, it seems.

Signed-off-by: Yuki Okushi &lt;jtitor@2k36.org&gt;
diff --git a/compiler/rustc_passes/src/reachable.rs b/compiler/rustc_passes/src/reachable.rs
@@ -316,8 +316,6 @@ fn check_item<'tcx>(
         item.kind
     {
         if !access_levels.is_reachable(item.def_id) {
-            // FIXME(#53488) remove `let`
-            let tcx = tcx;
             worklist.extend(items.iter().map(|ii_ref| ii_ref.id.def_id));
 
             let Res::Def(DefKind::Trait, trait_def_id) = trait_ref.path.res else {

Original file line number	Diff line number	Diff line change
`@@ -316,8 +316,6 @@ fn check_item<'tcx>(`
`316`	`316`	`item.kind`
`317`	`317`	`{`
`318`	`318`	`if !access_levels.is_reachable(item.def_id) {`
`319`		- // FIXME(#53488) remove `let`
`320`		`- let tcx = tcx;`
`321`	`319`	`worklist.extend(items.iter().map(\|ii_ref\| ii_ref.id.def_id));`
`322`	`320`
`323`	`321`	`let Res::Def(DefKind::Trait, trait_def_id) = trait_ref.path.res else {`