Do not assert layout in KnownPanicsLint.

Author: cjgillot

compiler/rustc_const_eval/src/interpret/operand.rs

@@ -243,6 +243,17 @@ impl<'tcx, Prov: Provenance> std::ops::Deref for ImmTy<'tcx, Prov> {
 }
 
 impl<'tcx, Prov: Provenance> ImmTy<'tcx, Prov> {
+    #[inline(always)]
+    pub fn try_from_immediate(imm: Immediate<Prov>, layout: TyAndLayout<'tcx>) -> Option<Self> {
+        let matches_abi = match (imm, layout.backend_repr) {
+            (Immediate::Scalar(..), BackendRepr::Scalar(..)) => true,
+            (Immediate::ScalarPair(..), BackendRepr::ScalarPair(..)) => true,
+            (Immediate::Uninit, _) => layout.is_sized(),
+            _ => false,
+        };
+        if matches_abi { Some(ImmTy { imm, layout }) } else { None }
+    }
+
     #[inline]
     pub fn from_scalar(val: Scalar<Prov>, layout: TyAndLayout<'tcx>) -> Self {
         debug_assert!(layout.backend_repr.is_scalar(), "`ImmTy::from_scalar` on non-scalar layout");

compiler/rustc_const_eval/src/interpret/place.rs

@@ -313,6 +313,14 @@ impl<'tcx, Prov: Provenance> Projectable<'tcx, Prov> for PlaceTy<'tcx, Prov> {
 
 // These are defined here because they produce a place.
 impl<'tcx, Prov: Provenance> OpTy<'tcx, Prov> {
+    #[inline(always)]
+    pub fn try_as_immediate(&self) -> Option<ImmTy<'tcx, Prov>> {
+        match self.op() {
+            Operand::Indirect(_) => None,
+            Operand::Immediate(imm) => ImmTy::try_from_immediate(*imm, self.layout),
+        }
+    }
+
     #[inline(always)]
     pub fn as_mplace_or_imm(&self) -> Either<MPlaceTy<'tcx, Prov>, ImmTy<'tcx, Prov>> {
         match self.op() {

compiler/rustc_mir_transform/src/known_panics_lint.rs

@@ -263,9 +263,7 @@ impl<'mir, 'tcx> ConstPropagator<'mir, 'tcx> {
         // manually normalized.
         let val = self.tcx.try_normalize_erasing_regions(self.typing_env, c.const_).ok()?;
 
-        self.use_ecx(|this| this.ecx.eval_mir_constant(&val, c.span, None))?
-            .as_mplace_or_imm()
-            .right()
+        self.use_ecx(|this| this.ecx.eval_mir_constant(&val, c.span, None))?.try_as_immediate()
     }
 
     /// Returns the value, if any, of evaluating `place`.

tests/crashes/121176.rs

@@ -0,0 +1,14 @@
+//! Regression test for #121176
+//! KnownPanicsLint used to assert ABI compatibility in the interpreter,
+//! which ICEs with unsized statics.
+//@ needs-rustc-debug-assertions
+
+use std::fmt::Debug;
+
+static STATIC_1: dyn Debug + Sync = *();
+//~^ ERROR the size for values of type `(dyn Debug + Sync + 'static)` cannot be known
+//~| ERROR type `()` cannot be dereferenced
+
+fn main() {
+    println!("{:?}", &STATIC_1);
+}

tests/crashes/139872.rs

@@ -0,0 +1,19 @@
+error[E0277]: the size for values of type `(dyn Debug + Sync + 'static)` cannot be known at compilation time
+  --> $DIR/static-by-value-dyn.rs:8:1
+   |
+LL | static STATIC_1: dyn Debug + Sync = *();
+   | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
+   |
+   = help: the trait `Sized` is not implemented for `(dyn Debug + Sync + 'static)`
+   = note: statics and constants must have a statically known size
+
+error[E0614]: type `()` cannot be dereferenced
+  --> $DIR/static-by-value-dyn.rs:8:37
+   |
+LL | static STATIC_1: dyn Debug + Sync = *();
+   |                                     ^^^ can't be dereferenced
+
+error: aborting due to 2 previous errors
+
+Some errors have detailed explanations: E0277, E0614.
+For more information about an error, try `rustc --explain E0277`.

tests/crashes/140332.rs

@@ -0,0 +1,13 @@
+//! Regression test for #140332
+//! KnownPanicsLint used to assert ABI compatibility in the interpreter,
+//! which ICEs with unsized statics.
+
+static mut S: [i8] = ["Some thing"; 1];
+//~^ ERROR the size for values of type `[i8]` cannot be known
+//~| ERROR mismatched types
+//~| ERROR mismatched types
+
+fn main() {
+    assert_eq!(S, [0; 1]);
+    //~^ ERROR use of mutable static is unsafe
+}

tests/ui/mir/static-by-value-dyn.rs

@@ -0,0 +1,33 @@
+error[E0277]: the size for values of type `[i8]` cannot be known at compilation time
+  --> $DIR/static-by-value-slice.rs:5:1
+   |
+LL | static mut S: [i8] = ["Some thing"; 1];
+   | ^^^^^^^^^^^^^^^^^^ doesn't have a size known at compile-time
+   |
+   = help: the trait `Sized` is not implemented for `[i8]`
+   = note: statics and constants must have a statically known size
+
+error[E0308]: mismatched types
+  --> $DIR/static-by-value-slice.rs:5:23
+   |
+LL | static mut S: [i8] = ["Some thing"; 1];
+   |                       ^^^^^^^^^^^^ expected `i8`, found `&str`
+
+error[E0308]: mismatched types
+  --> $DIR/static-by-value-slice.rs:5:22
+   |
+LL | static mut S: [i8] = ["Some thing"; 1];
+   |                      ^^^^^^^^^^^^^^^^^ expected `[i8]`, found `[i8; 1]`
+
+error[E0133]: use of mutable static is unsafe and requires unsafe function or block
+  --> $DIR/static-by-value-slice.rs:11:16
+   |
+LL |     assert_eq!(S, [0; 1]);
+   |                ^ use of mutable static
+   |
+   = note: mutable statics can be mutated by multiple threads: aliasing violations or data races will cause undefined behavior
+
+error: aborting due to 4 previous errors
+
+Some errors have detailed explanations: E0133, E0277, E0308.
+For more information about an error, try `rustc --explain E0133`.