Remove BorrowckErrors::set_tainted_by_errors.

nnethercote · nnethercote · commit 3a02ebcac27f · 2024-02-02T13:27:57.000+11:00
It has no effect. Note that `infcx.set_tainted_by_errors()` is still
called, so taintedness is still being propagated.
diff --git a/compiler/rustc_borrowck/src/lib.rs b/compiler/rustc_borrowck/src/lib.rs
@@ -178,7 +178,6 @@ fn do_mir_borrowck<'tcx>(
     // Gather the upvars of a closure, if any.
     if let Some(e) = input_body.tainted_by_errors {
         infcx.set_tainted_by_errors(e);
-        errors.set_tainted_by_errors(e);
     }
 
     // Replace all regions with fresh inference variables. This
@@ -2438,10 +2437,6 @@ mod error {
         pub fn buffer_non_error(&mut self, t: DiagnosticBuilder<'_, ()>) {
             self.buffered.push(t.into_diagnostic());
         }
-
-        pub fn set_tainted_by_errors(&mut self, e: ErrorGuaranteed) {
-            self.tainted_by_errors = Some(e);
-        }
     }
 
     impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,6 @@ fn do_mir_borrowck<'tcx>(`
`178`	`178`	`// Gather the upvars of a closure, if any.`
`179`	`179`	`if let Some(e) = input_body.tainted_by_errors {`
`180`	`180`	`infcx.set_tainted_by_errors(e);`
`181`		`- errors.set_tainted_by_errors(e);`
`182`	`181`	`}`
`183`	`182`
`184`	`183`	`// Replace all regions with fresh inference variables. This`
`@@ -2438,10 +2437,6 @@ mod error {`
`2438`	`2437`	`pub fn buffer_non_error(&mut self, t: DiagnosticBuilder<'_, ()>) {`
`2439`	`2438`	`self.buffered.push(t.into_diagnostic());`
`2440`	`2439`	`}`
`2441`		`-`
`2442`		`- pub fn set_tainted_by_errors(&mut self, e: ErrorGuaranteed) {`
`2443`		`- self.tainted_by_errors = Some(e);`
`2444`		`- }`
`2445`	`2440`	`}`
`2446`	`2441`
`2447`	`2442`	`impl<'cx, 'tcx> MirBorrowckCtxt<'cx, 'tcx> {`