refactor: tidy codes

Signed-off-by: Jack Cherng <jfcherng@gmail.com>

Author: jfcherng

src/Renderer/Html/Combined.php

@@ -41,7 +41,7 @@ protected function redererChanges(array $changes): string
 
         $wrapperClasses = [
             ...$this->options['wrapperClasses'],
-            ...['diff', 'diff-html', 'diff-combined'],
+            'diff', 'diff-html', 'diff-combined',
         ];
 
         return
@@ -110,16 +110,19 @@ protected function renderTableHunks(array $hunks): string
      */
     protected function renderTableBlock(array $block): string
     {
-        static $callbacks = [
-            SequenceMatcher::OP_EQ => 'renderTableBlockEqual',
-            SequenceMatcher::OP_INS => 'renderTableBlockInsert',
-            SequenceMatcher::OP_DEL => 'renderTableBlockDelete',
-            SequenceMatcher::OP_REP => 'renderTableBlockReplace',
+        static $callbacks;
+
+        // @todo rewrite with "first-class callable" (PHP 8.1)
+        $callbacks ??= [
+            SequenceMatcher::OP_EQ => [$this, 'renderTableBlockEqual'],
+            SequenceMatcher::OP_INS => [$this, 'renderTableBlockInsert'],
+            SequenceMatcher::OP_DEL => [$this, 'renderTableBlockDelete'],
+            SequenceMatcher::OP_REP => [$this, 'renderTableBlockReplace'],
         ];
 
         return
             '<tbody class="change change-' . self::TAG_CLASS_MAP[$block['tag']] . '">' .
-                $this->{$callbacks[$block['tag']]}($block) .
+                $callbacks[$block['tag']]($block) .
             '</tbody>';
     }
 

src/Renderer/Html/Inline.php

@@ -30,7 +30,7 @@ protected function redererChanges(array $changes): string
 
         $wrapperClasses = [
             ...$this->options['wrapperClasses'],
-            ...['diff', 'diff-html', 'diff-inline'],
+            'diff', 'diff-html', 'diff-inline',
         ];
 
         return
@@ -112,16 +112,19 @@ protected function renderTableHunks(array $hunks): string
      */
     protected function renderTableBlock(array $block): string
     {
-        static $callbacks = [
-            SequenceMatcher::OP_EQ => 'renderTableBlockEqual',
-            SequenceMatcher::OP_INS => 'renderTableBlockInsert',
-            SequenceMatcher::OP_DEL => 'renderTableBlockDelete',
-            SequenceMatcher::OP_REP => 'renderTableBlockReplace',
+        static $callbacks;
+
+        // @todo rewrite with "first-class callable" (PHP 8.1)
+        $callbacks ??= [
+            SequenceMatcher::OP_EQ => [$this, 'renderTableBlockEqual'],
+            SequenceMatcher::OP_INS => [$this, 'renderTableBlockInsert'],
+            SequenceMatcher::OP_DEL => [$this, 'renderTableBlockDelete'],
+            SequenceMatcher::OP_REP => [$this, 'renderTableBlockReplace'],
         ];
 
         return
             '<tbody class="change change-' . self::TAG_CLASS_MAP[$block['tag']] . '">' .
-                $this->{$callbacks[$block['tag']]}($block) .
+                $callbacks[$block['tag']]($block) .
             '</tbody>';
     }
 

src/Renderer/Html/SideBySide.php

@@ -30,7 +30,7 @@ protected function redererChanges(array $changes): string
 
         $wrapperClasses = [
             ...$this->options['wrapperClasses'],
-            ...['diff', 'diff-html', 'diff-side-by-side'],
+            'diff', 'diff-html', 'diff-side-by-side',
         ];
 
         return
@@ -104,16 +104,19 @@ protected function renderTableHunks(array $hunks): string
      */
     protected function renderTableBlock(array $block): string
     {
-        static $callbacks = [
-            SequenceMatcher::OP_EQ => 'renderTableBlockEqual',
-            SequenceMatcher::OP_INS => 'renderTableBlockInsert',
-            SequenceMatcher::OP_DEL => 'renderTableBlockDelete',
-            SequenceMatcher::OP_REP => 'renderTableBlockReplace',
+        static $callbacks;
+
+        // @todo rewrite with "first-class callable" (PHP 8.1)
+        $callbacks ??= [
+            SequenceMatcher::OP_EQ => [$this, 'renderTableBlockEqual'],
+            SequenceMatcher::OP_INS => [$this, 'renderTableBlockInsert'],
+            SequenceMatcher::OP_DEL => [$this, 'renderTableBlockDelete'],
+            SequenceMatcher::OP_REP => [$this, 'renderTableBlockReplace'],
         ];
 
         return
             '<tbody class="change change-' . self::TAG_CLASS_MAP[$block['tag']] . '">' .
-                $this->{$callbacks[$block['tag']]}($block) .
+                $callbacks[$block['tag']]($block) .
             '</tbody>';
     }