Skip to content

Commit 4979a53

Browse files
committed
nits
Signed-off-by: Jack Cherng <jfcherng@gmail.com>
1 parent ffaefef commit 4979a53

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

UPGRADING/UPGRADING_v6.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ there is no breaking change for you so you do not have to do anything.
99

1010
### External Breaking Changes
1111

12-
- `Diff` has been renamed to `Differ`.
12+
- The `Diff` class has been renamed to `Differ`.
1313
It's easy to adapt to this by changing the class name.
1414

1515
- Now a `Renderer` has `render()` API, but a `Differ` does not.

src/Differ.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final class Differ
4444
private $isCacheDirty = true;
4545

4646
/**
47-
* @var null|SequenceMatcher the sequence matcher
47+
* @var SequenceMatcher the sequence matcher
4848
*/
4949
private $sequenceMatcher;
5050

src/Renderer/Html/AbstractHtml.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ abstract class AbstractHtml extends AbstractRenderer
3737
* based differences. Generally called by subclasses that generate a
3838
* HTML based diff and return an array of the changes to show in the diff.
3939
*
40+
* @param Differ $differ the differ object
41+
*
4042
* @return array an array of the generated changes, suitable for presentation in HTML
4143
*/
4244
public function getChanges(Differ $differ): array
@@ -47,9 +49,6 @@ public function getChanges(Differ $differ): array
4749
$this->options
4850
);
4951

50-
// As we'll be modifying old & new to include our change markers,
51-
// we need to get the contents and store them here. That way
52-
// we're not going to destroy the original data
5352
$old = $differ->getOld();
5453
$new = $differ->getNew();
5554

0 commit comments

Comments
 (0)