refactor: utilize PHP 7.4 typed properties

Signed-off-by: Jack Cherng <jfcherng@gmail.com>

Author: jfcherng

src/Differ.php

@@ -44,70 +44,64 @@ final class Differ
     /**
      * @var array array of the options that have been applied for generating the diff
      */
-    public $options = [];
+    public array $options = [];
 
     /**
      * @var string[] the old sequence
      */
-    private $old = [];
+    private array $old = [];
 
     /**
      * @var string[] the new sequence
      */
-    private $new = [];
+    private array $new = [];
 
     /**
      * @var bool is any of cached properties dirty?
      */
-    private $isCacheDirty = true;
+    private bool $isCacheDirty = true;
 
     /**
      * @var SequenceMatcher the sequence matcher
      */
-    private $sequenceMatcher;
+    private SequenceMatcher $sequenceMatcher;
 
-    /**
-     * @var int
-     */
-    private $oldSrcLength = 0;
+    private int $oldSrcLength = 0;
 
-    /**
-     * @var int
-     */
-    private $newSrcLength = 0;
+    private int $newSrcLength = 0;
 
     /**
      * @var int the end index for the old if the old has no EOL at EOF
      *          -1 means the old has an EOL at EOF
      */
-    private $oldNoEolAtEofIdx = -1;
+    private int $oldNoEolAtEofIdx = -1;
 
     /**
      * @var int the end index for the new if the new has no EOL at EOF
      *          -1 means the new has an EOL at EOF
      */
-    private $newNoEolAtEofIdx = -1;
+    private int $newNoEolAtEofIdx = -1;
 
     /**
      * @var int the result of comparing the old and the new with the spaceship operator
      *          -1 means old < new, 0 means old == new, 1 means old > new
      */
-    private $oldNewComparison = 0;
+    private int $oldNewComparison = 0;
 
     /**
      * @var int[][][] array containing the generated opcodes for the differences between the two items
      */
-    private $groupedOpcodes = [];
+    private array $groupedOpcodes = [];
 
     /**
      * @var int[][][] array containing the generated opcodes for the differences between the two items (GNU version)
      */
-    private $groupedOpcodesGnu = [];
+    private array $groupedOpcodesGnu = [];
 
     /**
      * @var array associative array of the default options available for the Differ class and their default value
      */
-    private static $defaultOptions = [
+    private static array $defaultOptions = [
         // show how many neighbor lines
         // Differ::CONTEXT_ALL can be used to show the whole file
         'context' => 3,

src/Factory/LineRendererFactory.php

@@ -14,7 +14,7 @@ final class LineRendererFactory
      *
      * @var AbstractLineRenderer[]
      */
-    private static $singletons = [];
+    private static array $singletons = [];
 
     /**
      * The constructor.

src/Factory/RendererFactory.php

@@ -14,7 +14,7 @@ final class RendererFactory
      *
      * @var AbstractRenderer[]
      */
-    private static $singletons = [];
+    private static array $singletons = [];
 
     /**
      * The constructor.

src/Renderer/AbstractRenderer.php

@@ -10,6 +10,8 @@
 
 /**
  * Base class for diff renderers.
+ *
+ * @todo use typed properties (BC breaking for public interface) in v7
  */
 abstract class AbstractRenderer implements RendererInterface
 {

src/Renderer/Html/LineRenderer/AbstractLineRenderer.php

@@ -8,6 +8,8 @@
 
 /**
  * Base renderer for rendering HTML-based line diffs.
+ *
+ * @todo use typed properties (BC breaking for public interface) in v7
  */
 abstract class AbstractLineRenderer implements LineRendererInterface
 {

src/Utility/Language.php

@@ -9,12 +9,12 @@ final class Language
     /**
      * @var string[] the translation dict
      */
-    private $translations = [];
+    private array $translations = [];
 
     /**
      * @var string the language name
      */
-    private $language = '_custom_';
+    private string $language = '_custom_';
 
     /**
      * The constructor.

tests/Utility/LanguageTest.php

@@ -16,10 +16,8 @@ final class LanguageTest extends TestCase
 {
     /**
      * The Language object.
-     *
-     * @var \Jfcherng\Diff\Utility\Language
      */
-    protected $languageObj;
+    protected Language $languageObj;
 
     /**
      * Set up the test environment.