Merge pull request #137 from JoshVanL/periodic-flushing

Adds --flush-interval to set the flush interval of proxy handler

Author: jetstack-bot

cmd/app/options/app.go

@@ -2,6 +2,8 @@
 package options
 
 import (
+	"time"
+
 	"github.com/spf13/pflag"
 	cliflag "k8s.io/component-base/cli/flag"
 
@@ -12,6 +14,8 @@ type KubeOIDCProxyOptions struct {
 	DisableImpersonation bool
 	ReadinessProbePort   int
 
+	FlushInterval time.Duration
+
 	ExtraHeaderOptions ExtraHeaderOptions
 	TokenPassthrough   TokenPassthroughOptions
 }
@@ -39,6 +43,12 @@ func (k *KubeOIDCProxyOptions) AddFlags(fs *pflag.FlagSet) *KubeOIDCProxyOptions
 	fs.IntVarP(&k.ReadinessProbePort, "readiness-probe-port", "P", 8080,
 		"Port to expose readiness probe.")
 
+	fs.DurationVar(&k.FlushInterval, "flush-interval", time.Millisecond*50,
+		"Specifies the interval to flush request bodies. If 0ms, "+
+			"no periodic flushing is done. A negative value means to flush "+
+			"immediately after each write. Streaming requests such as 'kubectl exec' "+
+			"will ignore this option and flush immediately.")
+
 	k.TokenPassthrough.AddFlags(fs)
 	k.ExtraHeaderOptions.AddFlags(fs)
 

cmd/app/run.go

@@ -76,6 +76,8 @@ func buildRunCommand(stopCh <-chan struct{}, opts *options.Options) *cobra.Comma
 				TokenReview:          opts.App.TokenPassthrough.Enabled,
 				DisableImpersonation: opts.App.DisableImpersonation,
 
+				FlushInterval: opts.App.FlushInterval,
+
 				ExtraUserHeaders:                opts.App.ExtraHeaderOptions.ExtraUserHeaders,
 				ExtraUserHeadersClientIPEnabled: opts.App.ExtraHeaderOptions.EnableClientIPExtraUserHeader,
 			}

pkg/proxy/proxy.go

@@ -43,6 +43,8 @@ type Options struct {
 	DisableImpersonation bool
 	TokenReview          bool
 
+	FlushInterval time.Duration
+
 	ExtraUserHeaders                map[string][]string
 	ExtraUserHeadersClientIPEnabled bool
 }
@@ -127,6 +129,7 @@ func (p *Proxy) Run(stopCh <-chan struct{}) (<-chan struct{}, error) {
 	proxyHandler := httputil.NewSingleHostReverseProxy(url)
 	proxyHandler.Transport = p
 	proxyHandler.ErrorHandler = p.Error
+	proxyHandler.FlushInterval = p.options.FlushInterval
 
 	waitCh, err := p.serve(proxyHandler, stopCh)
 	if err != nil {