Remove debugging transport and enable e2e log-level

Because venafi-connection-lib 0.5.1 includes the debugging roundtripper as part
of the default client.
Added debug logging to the ark-test-e2e so that I can see the debug logging
still working.

- Remove debug roundtripper from agent HTTP client
- Drop import of k8s.io/client-go/transport
- Enable verbose logging in e2e helm chart (set --log-level=6)

Signed-off-by: Richard Wall <richard.wall@cyberark.com>

Author: wallrj-cyberark

hack/ark/test-e2e.sh

@@ -71,6 +71,7 @@ helm upgrade agent "oci://${ARK_CHART}@${ARK_CHART_DIGEST}" \
      --wait \
      --create-namespace \
      --namespace "$NAMESPACE" \
+     --set-json extraArgs='["--log-level=6"]' \
      --set pprof.enabled=true \
      --set fullnameOverride=disco-agent \
      --set "image.digest=${ARK_IMAGE_DIGEST}" \

internal/cyberark/client_test.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/jetstack/venafi-connection-lib/http_client"
 	"github.com/stretchr/testify/require"
-	"k8s.io/client-go/transport"
 	"k8s.io/klog/v2"
 	"k8s.io/klog/v2/ktesting"
 
@@ -61,7 +60,6 @@ func TestCyberArkClient_PutSnapshot_RealAPI(t *testing.T) {
 
 	var rootCAs *x509.CertPool
 	httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs)
-	httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext)
 
 	cfg, err := cyberark.LoadClientConfigFromEnvironment()
 	if err != nil {

internal/cyberark/identity/cmd/testidentity/main.go

@@ -9,7 +9,6 @@ import (
 	"os/signal"
 
 	"github.com/jetstack/venafi-connection-lib/http_client"
-	"k8s.io/client-go/transport"
 	"k8s.io/klog/v2"
 
 	"github.com/jetstack/preflight/internal/cyberark/identity"
@@ -50,7 +49,6 @@ func run(ctx context.Context) error {
 
 	var rootCAs *x509.CertPool
 	httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs)
-	httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext)
 
 	sdClient := servicediscovery.New(httpClient)
 	services, err := sdClient.DiscoverServices(ctx, subdomain)

pkg/agent/config.go

@@ -15,7 +15,6 @@ import (
 	"github.com/spf13/cobra"
 	"gopkg.in/yaml.v3"
 	"k8s.io/client-go/rest"
-	"k8s.io/client-go/transport"
 
 	"github.com/jetstack/preflight/api"
 	"github.com/jetstack/preflight/pkg/client"
@@ -815,7 +814,6 @@ func validateCredsAndCreateClient(log logr.Logger, flagCredentialsPath, flagClie
 			rootCAs *x509.CertPool
 		)
 		httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs)
-		httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext)
 		outputClient, err = client.NewCyberArk(httpClient)
 		if err != nil {
 			errs = multierror.Append(errs, err)

pkg/client/client_cyberark_test.go

@@ -8,7 +8,6 @@ import (
 	"github.com/jetstack/venafi-connection-lib/http_client"
 	"github.com/stretchr/testify/require"
 	k8sversion "k8s.io/apimachinery/pkg/version"
-	"k8s.io/client-go/transport"
 	"k8s.io/klog/v2"
 	"k8s.io/klog/v2/ktesting"
 
@@ -59,7 +58,6 @@ func TestCyberArkClient_PostDataReadingsWithOptions_RealAPI(t *testing.T) {
 
 		var rootCAs *x509.CertPool
 		httpClient := http_client.NewDefaultClient(version.UserAgent(), rootCAs)
-		httpClient.Transport = transport.NewDebuggingRoundTripper(httpClient.Transport, transport.DebugByContext)
 
 		c, err := client.NewCyberArk(httpClient)
 		if err != nil {