[aisdk] Allow passing of provider metadata in tool definitions #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loreto
approved these changes
Nov 13, 2025
|
|
||
| strict := true // Default to true | ||
| if tool.ProviderMetadata != nil { | ||
| fmt.Println("provider metadata: ", tool.ProviderMetadata) |
| return nil, nil, fmt.Errorf("failed to convert tool parameters: %w", err) | ||
| } | ||
|
|
||
| strict := true // Default to true |
Contributor
There was a problem hiding this comment.
If I care too much what the right default is, I think both are sensible, but just FYI, I'm looking at the Vercel code and they seem to now default to false instead: https://github.com/vercel/ai/blob/main/packages/openai/src/responses/openai-responses-language-model.ts#L135
They also seem to have renamed it from StrictSchemas to StrictJSONSchema 🤷
Contributor
Author
There was a problem hiding this comment.
Kept default true for now
| strict := true // Default to true | ||
| if tool.ProviderMetadata != nil { | ||
| fmt.Println("provider metadata: ", tool.ProviderMetadata) | ||
| if metadata, ok := tool.ProviderMetadata.Get(ProviderName); ok { |
Contributor
There was a problem hiding this comment.
I believe there's a GetMetadata helper that you should use here. You should be able to find examples of it being used elsewhere in the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We need it so that we can specify whether the tool schema validation should be strict or not.
How was it tested?
Used with testpilot and its custom tools. I'll send a PR on axiom to show its usage too.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 License.
By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 License as stated in the Community Contribution License.