Skip to content

Commit 74f9c7d

Browse files
authored
Remove unnecessary debug logs (#161)
## Summary The auth library currently prints a bunch of debug information to the terminal. Remove that debug info.
1 parent 42fe1bc commit 74f9c7d

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

pkg/sandbox/auth/internal/authflow/authflow.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ func (f *AuthFlow) Exchange(code string) (*session.Token, error) {
6161
return nil, err
6262
}
6363

64+
// TODO: Add verification
6465
// err = f.verify(tok)
6566
// if err != nil {
6667
// return nil, err

pkg/sandbox/auth/internal/callbackserver/callbackserver.go

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package callbackserver
22

33
import (
4-
"fmt"
54
"net"
65
"net/http"
76
)
@@ -67,44 +66,30 @@ func (s *CallbackServer) Start() error {
6766
}
6867

6968
http.HandleFunc(s.path, func(w http.ResponseWriter, r *http.Request) {
70-
fmt.Println("callback received")
71-
defer func() {
72-
fmt.Println("callback handler exiting")
73-
// _ = s.Stop()
74-
}()
75-
7669
q := r.URL.Query()
7770
resp := Response{
7871
Error: q.Get("error"),
7972
Code: q.Get("code"),
8073
State: q.Get("state"),
8174
}
82-
fmt.Println("sending response")
8375
s.respCh <- resp
8476

8577
// TODO: define success and error redirects
86-
fmt.Println("redirecting")
8778
http.Redirect(w, r, "https://www.jetpack.io", http.StatusSeeOther)
8879
})
8980

90-
fmt.Println("starting server")
9181
if err := s.server.Serve(s.listener); err != nil && err != http.ErrServerClosed {
92-
fmt.Println("error starting server")
9382
return err
9483
}
95-
fmt.Println("server stopped")
9684
return nil
9785
}
9886

9987
func (s *CallbackServer) WaitForResponse() Response {
100-
fmt.Println("waiting for response")
10188
resp := <-s.respCh
102-
fmt.Println("got response")
10389
_ = s.Stop()
10490
return resp
10591
}
10692

10793
func (s *CallbackServer) Stop() error {
108-
fmt.Println("stopping server")
10994
return s.server.Close()
11095
}

0 commit comments

Comments
 (0)