fix: prevent double teardown on test environment error (#15731)

Author: noomorph

e2e/__tests__/environmentTeardownError.test.ts

@@ -0,0 +1,21 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import runJest from '../runJest';
+
+// This test ensures that if a custom environment's teardown throws, Jest reports the real error, not an internal error.
+describe('Environment Teardown Error', () => {
+  it('reports the error thrown from teardown() in a custom environment', () => {
+    const {stderr, exitCode} = runJest('environment-teardown-error');
+    expect(exitCode).toBe(1);
+    expect(stderr).toMatch('teardown error from custom environment');
+    // Should NOT contain the internal error that was seen in the regression
+    expect(stderr).not.toMatch(
+      'The "object" argument must be of type object. Received null',
+    );
+  });
+});

e2e/environment-teardown-error/EnvironmentWithTeardownError.js

@@ -0,0 +1,17 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+const NodeEnvironment = require('jest-environment-node').default;
+
+class EnvironmentWithTeardownError extends NodeEnvironment {
+  async teardown() {
+    await super.teardown();
+    throw new Error('teardown error from custom environment');
+  }
+}
+
+module.exports = EnvironmentWithTeardownError;

e2e/environment-teardown-error/__tests__/environmentTeardownError.test.js

@@ -0,0 +1,9 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+'use strict';
+
+test('Environment must tear down with a correct error stack trace', () => {});

e2e/environment-teardown-error/package.json

@@ -0,0 +1,5 @@
+{
+  "jest": {
+    "testEnvironment": "<rootDir>/EnvironmentWithTeardownError.js"
+  }
+}

packages/jest-runner/src/runTest.ts

@@ -217,8 +217,11 @@ async function runTestInternal(
       );
       sourcemapSupport.resetRetrieveHandlers();
 
-      await environment.teardown();
-      isTornDown = true;
+      try {
+        await environment.teardown();
+      } finally {
+        isTornDown = true;
+      }
     }
   };