-
Notifications
You must be signed in to change notification settings - Fork 243
docs(valid-title): add documentation for ignoreTypeOfTestName option
#1842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ignoreTypeOfTestName option
G-Rath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, this is good as-is but if you have the time it'd be good to have this also document ignoreTypeOfDescribeName.
Happy if you just want to say no to that though, as I can do it in a follow up 🙂
docs/rules/valid-title.md
Outdated
| When enabled, the type of the first argument to `describe` blocks won't be | ||
| checked. | ||
|
|
||
| #### `ignoreTypeOfTestName` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if we're going to add a section for this, we might as well use it for ignoreTypeOfDescribeName too, like mustMatch and mustNotMatch below
G-Rath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh actually this does need to be formatted with prettier before it can be landed 😅
That is already documented. |
G-Rath
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
|
🎉 This PR is included in version 29.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.