Add proper checks to udp module send (#1924)

Fixes #1904

IoT.js-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

Author: Daniel Balla

src/modules/iotjs_module_udp.c

@@ -183,15 +183,22 @@ static void on_send(uv_udp_send_t* req, int status) {
 JS_FUNCTION(udp_send) {
   JS_DECLARE_PTR(jthis, uv_udp_t, udp_handle);
   DJS_CHECK_ARGS(3, object, number, string);
-  IOTJS_ASSERT(jerry_value_is_function(jargv[3]) ||
-               jerry_value_is_undefined(jargv[3]));
+
+  if (!jerry_value_is_undefined(jargv[3]) &&
+      !jerry_value_is_function(jargv[3])) {
+    return JS_CREATE_ERROR(TYPE, "Invalid callback given");
+  }
 
   const jerry_value_t jbuffer = JS_GET_ARG(0, object);
   const unsigned short port = JS_GET_ARG(1, number);
   iotjs_string_t address = JS_GET_ARG(2, string);
   jerry_value_t jcallback = JS_GET_ARG(3, object);
 
-  iotjs_bufferwrap_t* buffer_wrap = iotjs_bufferwrap_from_jbuffer(jbuffer);
+  iotjs_bufferwrap_t* buffer_wrap = iotjs_jbuffer_get_bufferwrap_ptr(jbuffer);
+  if (buffer_wrap == NULL) {
+    return JS_CREATE_ERROR(TYPE, "Invalid buffer given");
+  }
+
   size_t len = iotjs_bufferwrap_length(buffer_wrap);
 
   uv_req_t* req_send =

test/run_pass/issue/issue-1904.js

@@ -0,0 +1,25 @@
+/* Copyright 2019-present Samsung Electronics Co., Ltd. and other contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+var module = require('module');
+var dgram = require('dgram');
+var assert = require('assert');
+
+try {
+    dgram.createSocket('udp4')._handle.send(this, 0, '', new module());
+    assert(false);
+} catch (e) {
+    assert(e instanceof TypeError);
+}

test/testsets.json

@@ -1032,6 +1032,12 @@
       "required-modules": [
         "websocket"
       ]
+    },
+    {
+      "name": "issue-1904.js",
+      "required-modules": [
+        "dgram"
+      ]
     }
   ],
   "run_fail": [