Add an extra check to the stats object (#1919)

Fixes #1917

IoT.js-DCO-1.0-Signed-off-by: Daniel Balla dballa@inf.u-szeged.hu

Author: Daniel Balla

src/modules/iotjs_module_fs.c

@@ -451,6 +451,11 @@ JS_FUNCTION(fs_read_dir) {
 static jerry_value_t stats_is_typeof(jerry_value_t stats, int type) {
   jerry_value_t mode = iotjs_jval_get_property(stats, IOTJS_MAGIC_STRING_MODE);
 
+  if (!jerry_value_is_number(mode)) {
+    jerry_release_value(mode);
+    return JS_CREATE_ERROR(TYPE, "fstat: file mode should be a number");
+  }
+
   int mode_number = (int)iotjs_jval_as_number(mode);
 
   jerry_release_value(mode);

test/run_fail/test-issue-1917.js

@@ -0,0 +1,17 @@
+/* Copyright 2019-present Samsung Electronics Co., Ltd. and other contributors
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+var fs = require('fs')
+setInterval(fs.fstatSync(1).isFile, 1);

test/testsets.json

@@ -1111,6 +1111,13 @@
     {
       "name": "test_timers_issue_1353.js",
       "expected-failure": true
+    },
+    {
+      "name": "test-issue-1917.js",
+      "expected-failure": true,
+      "required-modules": [
+        "fs"
+      ]
     }
   ],
   "node/parallel": [