replace RUN_SCRIPTS with ADMINISTER

jtnord · web-flow · commit e35d0ba5dc70 · 2025-06-24T17:36:30.000+01:00
replace RUN_SCRIPTS with ADMINISTER

RUN SCripts is deprecated and realms don;t grant it on its own without ADMINISTER as it really is ADMINISTER.

Just check ADMINISTER
diff --git a/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPrivateKey.java b/src/main/java/com/cloudbees/jenkins/plugins/sshcredentials/impl/BasicSSHUserPrivateKey.java
@@ -443,7 +443,7 @@ private Object readResolve() {
                 return new DirectEntryPrivateKeySource(privateKeyFile);
             }
 
-            Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);
+            Jenkins.get().checkPermission(Jenkins.ADMINISTER);
 
             LOGGER.log(Level.INFO, "SECURITY-440: Migrating FileOnMasterPrivateKeySource to DirectEntryPrivateKeySource");
             // read the content of the file and then migrate to Direct
@@ -530,7 +530,7 @@ public long getPrivateKeysLastModified() {
         }
 
         private Object readResolve() {
-            Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);
+            Jenkins.get().checkPermission(Jenkins.ADMINISTER);
 
             LOGGER.log(Level.INFO, "SECURITY-440: Migrating UsersPrivateKeySource to DirectEntryPrivateKeySource");
             // read the content of the file and then migrate to Direct

Original file line number	Diff line number	Diff line change
`@@ -443,7 +443,7 @@ private Object readResolve() {`
`443`	`443`	`return new DirectEntryPrivateKeySource(privateKeyFile);`
`444`	`444`	`}`
`445`	`445`
`446`		`- Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);`
	`446`	`+ Jenkins.get().checkPermission(Jenkins.ADMINISTER);`
`447`	`447`
`448`	`448`	`LOGGER.log(Level.INFO, "SECURITY-440: Migrating FileOnMasterPrivateKeySource to DirectEntryPrivateKeySource");`
`449`	`449`	`// read the content of the file and then migrate to Direct`
`@@ -530,7 +530,7 @@ public long getPrivateKeysLastModified() {`
`530`	`530`	`}`
`531`	`531`
`532`	`532`	`private Object readResolve() {`
`533`		`- Jenkins.get().checkPermission(Jenkins.RUN_SCRIPTS);`
	`533`	`+ Jenkins.get().checkPermission(Jenkins.ADMINISTER);`
`534`	`534`
`535`	`535`	`LOGGER.log(Level.INFO, "SECURITY-440: Migrating UsersPrivateKeySource to DirectEntryPrivateKeySource");`
`536`	`536`	`// read the content of the file and then migrate to Direct`