From 5c812a8d53228e599a4dff0a9f0be3d591c7fe1e Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Tue, 9 Aug 2022 03:24:54 +0000 Subject: [PATCH] vuln-fix: Temporary Directory Hijacking or Information Disclosure This fixes either Temporary Directory Hijacking, or Temporary Directory Local Information Disclosure. Weakness: CWE-379: Creation of Temporary File in Directory with Insecure Permissions Severity: High CVSSS: 7.3 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.UseFilesCreateTempDirectory) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/10 Co-authored-by: Moderne --- .../util/ScmSyncConfigurationBaseTest.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/test/java/hudson/plugins/scm_sync_configuration/util/ScmSyncConfigurationBaseTest.java b/src/test/java/hudson/plugins/scm_sync_configuration/util/ScmSyncConfigurationBaseTest.java index 2bef1afe..4bd138ee 100644 --- a/src/test/java/hudson/plugins/scm_sync_configuration/util/ScmSyncConfigurationBaseTest.java +++ b/src/test/java/hudson/plugins/scm_sync_configuration/util/ScmSyncConfigurationBaseTest.java @@ -38,6 +38,7 @@ import java.io.File; import java.io.IOException; import java.lang.reflect.Field; +import java.nio.file.Files; import java.util.List; import java.util.regex.Pattern; @@ -143,9 +144,7 @@ protected String getHudsonRootBaseTemplate(){ } protected static File createTmpDirectory(String directoryPrefix) throws IOException { - final File temp = File.createTempFile(directoryPrefix, Long.toString(System.nanoTime())); - if(!(temp.delete())) { throw new IOException("Could not delete temp file: " + temp.getAbsolutePath()); } - if(!(temp.mkdir())) { throw new IOException("Could not create temp directory: " + temp.getAbsolutePath()); } + final File temp = Files.createTempDirectory(directoryPrefix + Long.toString(System.nanoTime())).toFile(); return (temp); }