Fix hierarchy deletion issues (JENKINS-26652)

Before deleting the job hierarchy it is needed to check for changes on the files, e.g config.xml. While deleting a job it gets updated, this blocks the git -rm command from deleting this hierarchy. Commits should always come with proper messages, git command fails if the commit message is empty. Which put scm-sync in an dirty state if there are commits which cannot be pushed.

Author: zilmTT

src/main/java/hudson/plugins/scm_sync_configuration/SCMManipulator.java

@@ -9,6 +9,7 @@
 import org.apache.maven.scm.command.checkin.CheckInScmResult;
 import org.apache.maven.scm.command.checkout.CheckOutScmResult;
 import org.apache.maven.scm.command.remove.RemoveScmResult;
+import org.apache.maven.scm.command.status.StatusScmResult;
 import org.apache.maven.scm.command.update.UpdateScmResult;
 import org.apache.maven.scm.manager.NoSuchScmProviderException;
 import org.apache.maven.scm.manager.ScmManager;
@@ -18,6 +19,7 @@
 import java.io.IOException;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Iterator;
 import java.util.List;
 import java.util.logging.Level;
 import java.util.logging.Logger;
@@ -124,7 +126,17 @@ public List<File> deleteHierarchy(File hierarchyToDelete){
 
         try {
             ScmFileSet deleteFileSet = new ScmFileSet(enclosingDirectory, hierarchyToDelete);
-            RemoveScmResult removeResult = this.scmManager.remove(this.scmRepository, deleteFileSet, "");
+            StatusScmResult checkForChanges = this.scmManager.status(scmRepository, deleteFileSet);
+            LOGGER.fine("Checking for changes on SCM hierarchy ["+hierarchyToDelete.getAbsolutePath()+"] from SCM ...");
+            for (ScmFile changedFile : checkForChanges.getChangedFiles()) {
+                //check in this change as it affect our hierarchy
+                LOGGER.fine("[checkForChanges] Found changed file "+changedFile.toString()+", try to check-in...");
+                CheckInScmResult checkedInChangedFile = scmManager.checkIn(scmRepository, new ScmFileSet(enclosingDirectory.getParentFile(), new File(changedFile.getPath())), "Check-In changes for "+changedFile.getPath());
+                if(!checkedInChangedFile.isSuccess()){
+                  LOGGER.severe("[checkForChanges] Failed to check-in changed file ["+changedFile.getPath()+"]: "+checkedInChangedFile.getProviderMessage());
+              }
+            }
+            RemoveScmResult removeResult = this.scmManager.remove(this.scmRepository, deleteFileSet, "Delete hierarchy "+hierarchyToDelete.getPath());
             if(!removeResult.isSuccess()){
                 LOGGER.severe("[deleteHierarchy] Problem during remove : "+removeResult.getProviderMessage());
                 return null;