Cleanup: minor fixes.

* ScmSyncGitCheckInCommand: typo in a code path that is never taken
  in this plugin (it always calls checkIn with only a directory, no
  files).
* Commit: check for user != null. Is that null check needed at all?
* FixedGitStatusConsumer: use simpler & more efficient File.replace()
  instead of File.replaceAll(). File.separator is guaranteed to be the
  single character File.separatorChar per its contract.

Author: tomaswolf

src/main/java/hudson/plugins/scm_sync_configuration/model/Commit.java

@@ -43,10 +43,10 @@ private static String createCommitMessage(ScmContext context, String messagePref
    	    if (user != null) {
    		    commitMessage.append(user.getId()).append(": ");
    	    }
-   	    commitMessage.append(messagePrefix);
-   	    commitMessage.append("\n\n");
-   	    commitMessage.append("Change performed by ").append(user.getDisplayName());
-   	    commitMessage.append('\n');
+   	    commitMessage.append(messagePrefix).append('\n');
+   	    if (user != null) {
+   	    	commitMessage.append('\n').append("Change performed by ").append(user.getDisplayName()).append('\n');
+   	    }
    	    if (userComment != null && !"".equals(userComment.trim())){
    	   	    commitMessage.append('\n').append(userComment.trim());
    	   	}

src/main/java/hudson/plugins/scm_sync_configuration/scms/customproviders/git/gitexe/FixedGitStatusConsumer.java

@@ -193,7 +193,7 @@ else if ( ( matcher = RENAMED_PATTERN.matcher( line ) ).find() )
         }
 
         for (String file : files) {
-            changedFiles.add(new ScmFile(file.replaceAll(File.separator, "/"), status));
+            changedFiles.add(new ScmFile(file.replace(File.separatorChar, '/'), status));
         }
     }
 

src/main/java/hudson/plugins/scm_sync_configuration/scms/customproviders/git/gitexe/ScmSyncGitCheckInCommand.java

@@ -67,7 +67,7 @@ protected CheckInScmResult executeCheckInCommand(
             	ScmSyncGitAddCommand addCommand = new ScmSyncGitAddCommand();
             	addCommand.setLogger(getLogger());
             	AddScmResult addResult = addCommand.executeAddFileSet(fileSet);
-            	if (addResult != null && addResult.isSuccess()) {
+            	if (addResult != null && !addResult.isSuccess()) {
                     return new CheckInScmResult(new ArrayList<ScmFile>(), addResult);
                 }
             }