Upgrade Commons Lang from 2 to 3 (#340)

Author: basil

pom.xml

@@ -94,6 +94,10 @@
       <groupId>io.jenkins.plugins</groupId>
       <artifactId>asm-api</artifactId>
     </dependency>
+    <dependency>
+      <groupId>io.jenkins.plugins</groupId>
+      <artifactId>commons-lang3-api</artifactId>
+    </dependency>
     <dependency>
       <groupId>org.jenkins-ci.plugins</groupId>
       <artifactId>structs</artifactId>

src/main/java/jenkins/scm/api/MethodUtils.java

@@ -30,8 +30,8 @@
 import java.util.Arrays;
 import java.util.List;
 import edu.umd.cs.findbugs.annotations.NonNull;
-import org.apache.commons.lang.ClassUtils;
-import org.apache.commons.lang.Validate;
+import org.apache.commons.lang3.ClassUtils;
+import org.apache.commons.lang3.Validate;
 
 /**
  * Helper to identify methods that have not been implemented / overridden.

src/main/java/jenkins/scm/api/SCMCategory.java

@@ -38,7 +38,7 @@
 import java.util.Set;
 import java.util.TreeMap;
 import java.util.TreeSet;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jvnet.localizer.Localizable;
 
 /**

src/main/java/jenkins/scm/api/SCMEvent.java

@@ -49,7 +49,7 @@
 import jakarta.servlet.http.HttpServletRequest;
 import jenkins.security.ImpersonatingScheduledExecutorService;
 import jenkins.util.SystemProperties;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.stapler.Stapler;

src/main/java/jenkins/scm/api/SCMFile.java

@@ -34,7 +34,7 @@
 import java.util.Collections;
 import java.util.List;
 import org.apache.commons.io.IOUtils;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.WebApp;
 
 /**

src/main/java/jenkins/scm/api/SCMHeadMixinEqualityGenerator.java

@@ -41,7 +41,7 @@
 import java.util.concurrent.locks.ReentrantReadWriteLock;
 import jenkins.scm.api.mixin.SCMHeadMixin;
 import net.jcip.annotations.GuardedBy;
-import org.apache.commons.lang.ClassUtils;
+import org.apache.commons.lang3.ClassUtils;
 import org.objectweb.asm.ClassWriter;
 import org.objectweb.asm.Label;
 import org.objectweb.asm.MethodVisitor;
@@ -175,7 +175,7 @@ private SCMHeadMixinEqualityGenerator(ClassLoader parent) {
     @NonNull
     private SCMHeadMixin.Equality create(@NonNull Class<? extends SCMHead> type) {
         Map<String, Method> properties = new TreeMap<>();
-        for (Class clazz : (List<Class>) ClassUtils.getAllInterfaces(type)) {
+        for (Class clazz : ClassUtils.getAllInterfaces(type)) {
             if (!SCMHeadMixin.class.isAssignableFrom(clazz)) {
                 // not a mix-in
                 continue;

src/main/java/jenkins/scm/api/SCMName.java

@@ -37,7 +37,7 @@
 import java.util.List;
 import java.util.Locale;
 
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 /**
  * Utility class to help with naming SCM related things.

src/main/java/jenkins/scm/api/metadata/AvatarMetadataAction.java

@@ -35,7 +35,7 @@
 import jenkins.scm.api.SCMSource;
 import jenkins.scm.impl.avatars.AvatarCache;
 import org.apache.commons.jelly.JellyContext;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jenkins.ui.icon.Icon;
 import org.jenkins.ui.icon.IconSet;
 import org.jenkins.ui.icon.IconSpec;

src/main/java/jenkins/scm/impl/avatars/AvatarCache.java

@@ -60,7 +60,7 @@
 import jakarta.servlet.http.HttpServletResponse;
 import jenkins.model.Jenkins;
 
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.kohsuke.stapler.HttpResponse;
 import org.kohsuke.stapler.QueryParameter;
 import org.kohsuke.stapler.StaplerRequest2;

src/main/java/jenkins/scm/impl/trait/WildcardSCMHeadFilterTrait.java

@@ -34,7 +34,7 @@
 import jenkins.scm.api.trait.SCMSourceContext;
 import jenkins.scm.api.trait.SCMSourceTrait;
 import jenkins.scm.api.trait.SCMSourceTraitDescriptor;
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;