BugFix prevent exception exposing internal logic/data

Author: nhojpatrick

src/main/java/org/jenkinsci/plugins/gogs/GogsWebHook.java

@@ -97,7 +97,22 @@ private static String encode(String data, String key) throws Exception {
      * @throws IOException problem while parsing
      */
     public void doIndex(StaplerRequest req, StaplerResponse rsp) throws IOException {
+
         GogsResults result = new GogsResults();
+
+        try {
+            internalDoIndex(result, req, rsp);
+
+        } catch (final RuntimeException re) {
+            LOGGER.severe(re.toString());
+            result.setStatus(500, "GogsWebHook execution error.");
+            exitWebHook(result, rsp);
+            return;
+        }
+    }
+
+    void internalDoIndex(GogsResults result, StaplerRequest req, StaplerResponse rsp) throws IOException {
+
         GogsPayloadProcessor payloadProcessor = new GogsPayloadProcessor();
 
         //Check that we have something to process

src/test/java/org/jenkinsci/plugins/gogs/GogsWebHookTest.java

@@ -50,7 +50,7 @@ public void callDoIndexWithNullReqMessageMustThrowException() throws IOException
         GogsWebHook gogsWebHook = new GogsWebHook();
         StaplerResponse staplerResponse = Mockito.mock(ResponseImpl.class);
         try {
-            gogsWebHook.doIndex(null, staplerResponse);
+            gogsWebHook.internalDoIndex(new GogsResults(),null, staplerResponse);
         } catch (NullPointerException e) {
             String expectedErrMsg = "Null request submitted to doIndex method";
             assertEquals("Not the expected error message.", expectedErrMsg, e.getMessage());
@@ -65,7 +65,7 @@ public void callDoIndexWithNullResponseMessageMustThrowException() throws IOExce
         GogsWebHook gogsWebHook = new GogsWebHook();
         StaplerRequest staplerRequest = Mockito.mock(RequestImpl.class);
         try {
-            gogsWebHook.doIndex(staplerRequest, null);
+            gogsWebHook.internalDoIndex(new GogsResults(), staplerRequest, null);
         } catch (NullPointerException e) {
             String expectedErrMsg = "Null reply submitted to doIndex method";
             assertEquals("Not the expected error message.", expectedErrMsg, e.getMessage());
@@ -128,7 +128,7 @@ public void whenQueryStringIsNullMustThrowException() throws Exception {
 
 
         try {
-            gogsWebHook.doIndex(staplerRequest, staplerResponse);
+            gogsWebHook.internalDoIndex(new GogsResults(), staplerRequest, staplerResponse);
         } catch (NullPointerException e) {
             String expectedErrMsg = "The queryString in the request is null";
             assertEquals("Not the expected error message.", expectedErrMsg, e.getMessage());