Fix permission type in checkAgentUserPermission function

Brinkop Andre (uib05464) · scurvydoggo · commit 2feb79bd4397 · 2023-07-26T11:15:47.000+10:00
diff --git a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java
@@ -250,11 +250,10 @@ private boolean checkReadPermission(@NonNull Permission permission) {
     }
 
     private boolean checkAgentUserPermission(@NonNull Permission permission) {
-        String id = permission.getId();
-        return (id.equals(Hudson.READ)
-                || id.equals(Computer.CREATE)
-                || id.equals(Computer.CONNECT)
-                || id.equals(Computer.CONFIGURE));
+        return permission.equals(Hudson.READ)
+                || permission.equals(Computer.CREATE)
+                || permission.equals(Computer.CONNECT)
+                || permission.equals(Computer.CONFIGURE);
     }
 
     private boolean checkJobStatusPermission(@NonNull Permission permission) {

Original file line number	Diff line number	Diff line change
`@@ -250,11 +250,10 @@ private boolean checkReadPermission(@NonNull Permission permission) {`
`250`	`250`	`}`
`251`	`251`
`252`	`252`	`private boolean checkAgentUserPermission(@NonNull Permission permission) {`
`253`		`- String id = permission.getId();`
`254`		`- return (id.equals(Hudson.READ)`
`255`		`- \|\| id.equals(Computer.CREATE)`
`256`		`- \|\| id.equals(Computer.CONNECT)`
`257`		`- \|\| id.equals(Computer.CONFIGURE));`
	`253`	`+ return permission.equals(Hudson.READ)`
	`254`	`+ \|\| permission.equals(Computer.CREATE)`
	`255`	`+ \|\| permission.equals(Computer.CONNECT)`
	`256`	`+ \|\| permission.equals(Computer.CONFIGURE);`
`258`	`257`	`}`
`259`	`258`
`260`	`259`	`private boolean checkJobStatusPermission(@NonNull Permission permission) {`