From 65d549535ed5abe4a5aae90c609be66378033e97 Mon Sep 17 00:00:00 2001
From: Jon Sten
Date: Thu, 9 Jan 2020 07:21:21 +0100
Subject: [PATCH 1/2] Remove automatic fingerprinting from Image.inside() step.
Automatic fingerprinting was removed in PR #180, but for some reason
Image.inside() was left unchanged.
Also removes incorrect documentation that was missed in PR #180.
---
.../jenkinsci/plugins/docker/workflow/WithContainerStep.java | 1 -
.../org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly | 2 --
2 files changed, 3 deletions(-)
diff --git a/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java b/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
index 8c6ccfb1a..2aae84a00 100644
--- a/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
+++ b/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
@@ -206,7 +206,6 @@ public Execution() {
"Alternatively you can force image entrypoint to be disabled by adding option `--entrypoint=''`.");
}
- DockerFingerprints.addRunFacet(dockerClient.getContainerRecord(env, container), run);
ImageAction.add(step.image, run);
getContext().newBodyInvoker().
withContext(BodyInvoker.mergeLauncherDecorators(getContext().get(LauncherDecorator.class), new Decorator(container, envHost, ws, toolName, dockerVersion))).
diff --git a/src/main/resources/org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly b/src/main/resources/org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly
index b236bd723..f5344c4dd 100644
--- a/src/main/resources/org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly
+++ b/src/main/resources/org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly
@@ -47,7 +47,6 @@
Runs docker build to create and tag the specified image from a Dockerfile in the current directory.
Additional args may be added, such as '-f Dockerfile.other --pull --build-arg http_proxy=http://192.168.1.1:3128 .'. Like docker build, args must end with the build context.
Returns the resulting Image object.
- Records a FROM fingerprint in the build.
Image.id
@@ -62,7 +61,6 @@
Uses docker run to run the image, and returns a Container which you could stop later.
Additional args may be added, such as '-p 8080:8080 --memory-swap=-1'.
Optional command is equivalent to Docker command specified after the image.
- Records a run fingerprint in the build.
Image.withRun[(args[, command])] {…}
From 7e05f2cd922231ae79bce22099d8110b6a732ec4 Mon Sep 17 00:00:00 2001
From: Jon Sten
Date: Thu, 9 Jan 2020 12:58:08 +0100
Subject: [PATCH 2/2] Removed unused import
---
.../org/jenkinsci/plugins/docker/workflow/WithContainerStep.java | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java b/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
index 2aae84a00..41f4910b3 100644
--- a/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
+++ b/src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java
@@ -49,7 +49,6 @@
import java.util.Map;
import java.util.Set;
import java.util.TreeSet;
-import org.jenkinsci.plugins.docker.commons.fingerprint.DockerFingerprints;
import org.jenkinsci.plugins.docker.commons.tools.DockerTool;
import org.jenkinsci.plugins.docker.workflow.client.DockerClient;
import org.jenkinsci.plugins.docker.workflow.client.WindowsDockerClient;