Skip to content

Commit c97bf23

Browse files
authored
escape double quotes in env variables under windows (#220)
* update jenkins to 2.190.1 * escape double quotes in env variables under windows
1 parent eb0b0db commit c97bf23

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

pom.xml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
<properties>
3232
<revision>1.25</revision>
3333
<changelist>-SNAPSHOT</changelist>
34-
<jenkins.version>2.176.4</jenkins.version>
34+
<jenkins.version>2.190.1</jenkins.version>
3535
<java.level>8</java.level>
3636
<pipeline-model-definition-plugin.version>1.5.1</pipeline-model-definition-plugin.version>
3737
</properties>
@@ -51,7 +51,7 @@
5151
<dependencies>
5252
<dependency>
5353
<groupId>io.jenkins.tools.bom</groupId>
54-
<artifactId>bom-2.176.x</artifactId>
54+
<artifactId>bom-2.190.x</artifactId>
5555
<version>11</version>
5656
<scope>import</scope>
5757
<type>pom</type>

src/main/java/org/jenkinsci/plugins/docker/workflow/client/WindowsDockerClient.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
import hudson.FilePath;
66
import hudson.Launcher;
77
import hudson.model.Node;
8+
import hudson.os.WindowsUtil;
89
import hudson.util.ArgumentListBuilder;
910

1011
import javax.annotation.CheckForNull;
@@ -46,7 +47,7 @@ public String run(@Nonnull EnvVars launchEnv, @Nonnull String image, @CheckForNu
4647
}
4748
for (Map.Entry<String, String> variable : containerEnv.entrySet()) {
4849
argb.add("-e");
49-
argb.addMasked(variable.getKey()+"="+variable.getValue());
50+
argb.addMasked(WindowsUtil.quoteArgument(variable.getKey() + "=" + variable.getValue()));
5051
}
5152
argb.add(image).add(command);
5253

0 commit comments

Comments
 (0)