Skip to content

Commit 65d5495

Browse files
committed
Remove automatic fingerprinting from Image.inside() step.
Automatic fingerprinting was removed in PR #180, but for some reason Image.inside() was left unchanged. Also removes incorrect documentation that was missed in PR #180.
1 parent 74a2370 commit 65d5495

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

src/main/java/org/jenkinsci/plugins/docker/workflow/WithContainerStep.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,6 @@ public Execution() {
206206
"Alternatively you can force image entrypoint to be disabled by adding option `--entrypoint=''`.");
207207
}
208208

209-
DockerFingerprints.addRunFacet(dockerClient.getContainerRecord(env, container), run);
210209
ImageAction.add(step.image, run);
211210
getContext().newBodyInvoker().
212211
withContext(BodyInvoker.mergeLauncherDecorators(getContext().get(LauncherDecorator.class), new Decorator(container, envHost, ws, toolName, dockerVersion))).

src/main/resources/org/jenkinsci/plugins/docker/workflow/DockerDSL/help.jelly

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@
4747
Runs <code>docker build</code> to create and tag the specified image from a <code>Dockerfile</code> in the current directory.
4848
Additional <code>args</code> may be added, such as <code>'-f Dockerfile.other --pull --build-arg http_proxy=http://192.168.1.1:3128 .'</code>. Like <code>docker build</code>, <code>args</code> must end with the build context.
4949
Returns the resulting <code>Image</code> object.
50-
Records a <code>FROM</code> fingerprint in the build.
5150
</p>
5251
</dd>
5352
<dt><code>Image.id</code></dt>
@@ -62,7 +61,6 @@
6261
Uses <code>docker run</code> to run the image, and returns a <code>Container</code> which you could <code>stop</code> later.
6362
Additional <code>args</code> may be added, such as <code>'-p 8080:8080 --memory-swap=-1'</code>.
6463
Optional <code>command</code> is equivalent to Docker command specified after the image.
65-
Records a run fingerprint in the build.
6664
</p>
6765
</dd>
6866
<dt><code>Image.withRun[(args[, command])] {…}</code></dt>

0 commit comments

Comments
 (0)