Skip to content

Commit 5c23a8e

Browse files
committed
Make class fields final
This reduces the probability of mutability issues.
1 parent 100695d commit 5c23a8e

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

src/main/java/org/jenkinsci/plugins/bitbucket/BitbucketBuildStatusNotifier.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ public class BitbucketBuildStatusNotifier extends Notifier {
5656

5757
private static final Logger logger = Logger.getLogger(BitbucketBuildStatusNotifier.class.getName());
5858

59-
private boolean notifyStart;
60-
private boolean notifyFinish;
61-
private boolean overrideLatestBuild;
62-
private String credentialsId;
59+
private final boolean notifyStart;
60+
private final boolean notifyFinish;
61+
private final boolean overrideLatestBuild;
62+
private final String credentialsId;
6363

6464
@DataBoundConstructor
6565
public BitbucketBuildStatusNotifier(final boolean notifyStart, final boolean notifyFinish,

src/main/java/org/jenkinsci/plugins/bitbucket/api/BitbucketApiService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,8 @@ public class BitbucketApiService extends OAuth20ServiceImpl {
3434
private static final String GRANT_TYPE_KEY = "grant_type";
3535
private static final String GRANT_TYPE_CLIENT_CREDENTIALS = "client_credentials";
3636

37-
private DefaultApi20 api;
38-
private OAuthConfig config;
37+
private final DefaultApi20 api;
38+
private final OAuthConfig config;
3939

4040
public BitbucketApiService(DefaultApi20 api, OAuthConfig config) {
4141
super(api, config);

src/main/java/org/jenkinsci/plugins/bitbucket/model/BitbucketBuildStatusResource.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ public class BitbucketBuildStatusResource {
3030

3131
private static final String API_ENDPOINT = "https://api.bitbucket.org/2.0/";
3232

33-
private String owner;
34-
private String repoSlug;
35-
private String commitId;
33+
private final String owner;
34+
private final String repoSlug;
35+
private final String commitId;
3636

3737
public BitbucketBuildStatusResource(String owner, String repoSlug, String commitId) {
3838
this.owner = owner;

0 commit comments

Comments
 (0)