Skip to content

Commit 37fa5f2

Browse files
committed
[Enh] add logger
1 parent 4882b4e commit 37fa5f2

File tree

7 files changed

+22
-11
lines changed

7 files changed

+22
-11
lines changed

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
"dependencies": {
77
"faker": "^4.1.0",
88
"gh-pages": "^1.0.0",
9+
"loglevel": "^1.4.1",
910
"prop-types": "^15.5.10",
1011
"react": "^15.6.1",
1112
"react-dom": "^15.6.1",

src/components/UserCreation/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React, { PureComponent } from 'react';
22
import PropTypes from 'prop-types';
33
import { Container, Row, Input, Button } from 'rebass';
4+
import logger from '../../utils/logger';
45

56
class UserCreation extends PureComponent {
67
static propTypes = {
@@ -23,7 +24,7 @@ class UserCreation extends PureComponent {
2324

2425
onSubmit = evt => {
2526
evt.preventDefault();
26-
console.warn('onSubmit');
27+
logger.warn('onSubmit');
2728
};
2829

2930
render() {

src/components/UserList/UserItem.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ class UserItem extends Component {
4646
};
4747

4848
render() {
49-
const { id, name, age, nickname, isEdit } = this.props;
49+
const { id, name, age, nickname } = this.props;
5050
return (
5151
<Row key={`${id}-${nickname}`}>
5252
<Column>

src/components/UserList/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import React, { Component } from 'react';
22
import PropTypes from 'prop-types';
33
import { Container, Row, Column, Divider } from 'rebass';
44
import UserItem from './UserItem';
5+
import logger from '../../utils/logger';
56

67
class UserList extends Component {
78
static propTypes = {
@@ -29,7 +30,7 @@ class UserList extends Component {
2930

3031
render() {
3132
const { users } = this.props;
32-
console.warn('User List', users);
33+
logger.warn('User List', users);
3334
return (
3435
<Container>
3536
<Row>

src/containers/Users/index.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ import {
99
removeUser,
1010
initFakeData
1111
} from '../../store/user';
12+
import logger from '../../utils/logger';
1213

1314
class Users extends Component {
1415
state = {
@@ -30,8 +31,8 @@ class Users extends Component {
3031
};
3132

3233
onAddUser = () => {
33-
const { newUser, users } = this.state;
34-
console.warn('onAddUser', newUser);
34+
const { newUser } = this.state;
35+
logger.warn('onAddUser', newUser);
3536
addUser(newUser, () => {
3637
this.setState({
3738
users: getUsers(),
@@ -45,7 +46,7 @@ class Users extends Component {
4546
};
4647

4748
onUpdateUser = (id, user) => {
48-
console.warn('onRemoveUser', id);
49+
logger.warn('onRemoveUser', id);
4950
updateUser(id, user, () => {
5051
this.setState({
5152
users: getUsers()
@@ -54,7 +55,7 @@ class Users extends Component {
5455
};
5556

5657
onRemoveUser = id => {
57-
console.warn('onRemoveUser', id);
58+
logger.warn('onRemoveUser', id);
5859
removeUser(id, () => {
5960
this.setState({
6061
users: getUsers()
@@ -80,7 +81,7 @@ class Users extends Component {
8081
hasChange = true;
8182
break;
8283
default:
83-
console.warn('unsupport field', field);
84+
logger.warn('unsupport field', field);
8485
}
8586
if (hasChange) {
8687
this.setState(prevState => ({
@@ -90,7 +91,7 @@ class Users extends Component {
9091
};
9192

9293
componentWillMount() {
93-
console.warn('componentWillMount');
94+
logger.warn('componentWillMount');
9495
initFakeData();
9596
this.setState({
9697
users: getUsers()

src/store/user.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import faker from 'faker';
2+
import logger from '../utils/logger';
23
const DB_KEY = 'REACT_USERS';
34
let data = [];
45

@@ -25,7 +26,7 @@ function initFakeData() {
2526
} catch (error) {
2627
data = [];
2728
}
28-
if (data.length === 0) {
29+
if (data && data.length === 0) {
2930
for (let index = 0; index < 5; index++) {
3031
data.push({
3132
id: faker.random.uuid(),
@@ -70,7 +71,7 @@ function updateUser(userId, user, callback) {
7071
}
7172

7273
function getUsers() {
73-
console.warn('getUsers', data);
74+
logger.warn('getUsers', data);
7475
return data;
7576
}
7677

src/utils/logger.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
import logger from 'loglevel';
2+
3+
const dev = process.env.NODE_ENV !== 'production';
4+
logger.setLevel(dev ? 'info' : 'error');
5+
6+
export default logger;

0 commit comments

Comments
 (0)