If an HTTPError occures the noscript-Tag will not be rendered, but the script-Tag

Author: gr4y

lib/jekyll-gist/gist_tag.rb

@@ -48,15 +48,24 @@ def gist_script_tag(gist_id, filename = nil)
       end
 
       def gist_noscript_tag(gist_id, filename = nil)
+        code = fetch_raw_code(gist_id, filename)
+        if !code.nil?
+          "<noscript><pre>#{CGI.escapeHTML(code)}</pre></noscript>"
+        end
+      end
+
+      def fetch_raw_code(gist_id, filename = nil)
         if filename.empty?
           uri = "https://gist.githubusercontent.com/#{gist_id}/raw"
         else
           uri = "https://gist.githubusercontent.com/#{gist_id}/raw/#{filename}"
         end
-        code = open(uri).read.chomp
-        "<noscript><pre>#{CGI.escapeHTML(code)}</pre></noscript>"
+        begin
+          open(uri).read.chomp
+        rescue OpenURI::HTTPError => e
+          nil
+        end
       end
-
     end
   end
 end

spec/gist_tag_spec.rb

@@ -94,13 +94,30 @@
       end
 
       it "produces the correct script tag" do
-        expect(output).to match(/<script src="https:\/\/gist.github.com\/#{doc.data['gist_id']}.js\?file=#{doc.data['gist_filename']}">\s<\/script>\n\n/)
+        expect(output).to match(/<script src="https:\/\/gist.github.com\/#{doc.data['gist_id']}.js\?file=#{doc.data['gist_filename']}">\s<\/script>/)
       end
 
       it "produces the correct noscript tag" do 
         expect(output).to match(/<noscript><pre>&lt;test&gt;true&lt;\/test&gt;<\/pre><\/noscript>\n/)
       end
     end
+
+    context "with valid gist id and invalid filename" do 
+      before { stub_request(:get, "https://gist.githubusercontent.com/#{gist_id}/raw/#{gist_filename}").to_return(status: 404) }
+      let(:gist_id)     { "mattr-/24081a1d93d2898ecf0f" }
+      let(:gist_filename) { "myfile.ext" }
+      let(:content)  { "{% gist #{gist_id} #{gist_filename} %}" }
+
+      it "produces the correct script tag" do
+        expect(output).to match(/<script src="https:\/\/gist.github.com\/#{gist_id}.js\?file=#{gist_filename}">\s<\/script>/)
+      end
+
+      it "doesn't produces the noscript tag" do 
+        expect(output).to_not match(/<noscript><pre>&lt;test&gt;true&lt;\/test&gt;<\/pre><\/noscript>\n/)
+      end
+
+    end
+
   end