Style: Add Rubocop

Author: DirtyF

.rubocop.yml

@@ -5,8 +5,24 @@ AllCops:
   TargetRubyVersion: 2.1
   Exclude:
     - vendor/**/*
+    - spec/*.rb
 
-Metrics/LineLength:
+Lint/IneffectiveAccessModifier:
   Exclude:
-    - spec/**/*
-    - jekyll-gist.gemspec
+    - lib/jekyll-gist/gist_tag.rb
+
+Lint/ShadowedException:
+  Exclude:
+    - lib/jekyll-gist/gist_tag.rb
+
+Metrics/AbcSize:
+  Exclude:
+    - lib/jekyll-gist/gist_tag.rb
+
+Metrics/MethodLength:
+  Exclude:
+    - lib/jekyll-gist/gist_tag.rb
+
+Style/PreferredHashMethods:
+  Exclude:
+    - lib/jekyll-gist/gist_tag.rb

Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 gemspec
 

Rakefile

@@ -1 +1,3 @@
+# frozen_string_literal: true
+
 require "bundler/gem_tasks"

jekyll-gist.gemspec

@@ -26,5 +26,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "jekyll", ">= 3.0"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"
+  spec.add_development_dependency "rubocop", "~> 0.51"
   spec.add_development_dependency "webmock"
 end

lib/jekyll-gist.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "jekyll-gist/version"
 require "jekyll-gist/gist_tag"
 

lib/jekyll-gist/gist_tag.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "cgi"
 require "net/http"
 require "octokit"
@@ -11,7 +13,7 @@ class GistTag < Liquid::Tag
       def render(context)
         @encoding = context.registers[:site].config["encoding"] || "utf-8"
         @settings = context.registers[:site].config["gist"]
-        if tag_contents = determine_arguments(@markup.strip)
+        if (tag_contents = determine_arguments(@markup.strip))
           gist_id = tag_contents[0]
           filename = tag_contents[1]
           if context_contains_key?(context, gist_id)
@@ -24,7 +26,7 @@ def render(context)
           script_tag = gist_script_tag(gist_id, filename)
           "#{noscript_tag}#{script_tag}"
         else
-          raise ArgumentError, <<-eos
+          raise ArgumentError, <<-EOS
   Syntax error in tag 'gist' while parsing the following markup:
 
     #{@markup}
@@ -34,7 +36,7 @@ def render(context)
     {% gist user/1234567 foo.js %}
     {% gist 28949e1d5ee2273f9fd3 %}
     {% gist 28949e1d5ee2273f9fd3 best.md %}
-  eos
+  EOS
         end
       end
 
@@ -74,9 +76,9 @@ def gist_noscript_tag(gist_id, filename = nil)
 
           "<noscript><pre>#{code}</pre></noscript>"
         else
-          Jekyll.logger.warn "Warning:", "The <noscript> tag for your gist #{gist_id} could not"
-          Jekyll.logger.warn "", "be generated. This will affect users who do not have"
-          Jekyll.logger.warn "", "JavaScript available or enabled in their browsers."
+          Jekyll.logger.warn "Warning:", "The <noscript> tag for your gist #{gist_id} "
+          Jekyll.logger.warn "", "could not be generated. This will affect users who do "
+          Jekyll.logger.warn "", "not have JavaScript enabled in their browsers."
         end
       end
 

lib/jekyll-gist/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Jekyll
   module Gist
     VERSION = "1.4.1".freeze

script/fmt

@@ -0,0 +1,4 @@
+#!/bin/bash
+set -e
+
+bundle exec rubocop -D -E

spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 TEST_DIR = __dir__
 TMP_DIR  = File.expand_path("../tmp", TEST_DIR)