Major code clean-up and quality improvements

Author: jeffreylanters

Runtime/Attributes/Asset.cs

@@ -1,45 +1,59 @@
 namespace ElRaccoone.EntityComponentSystem {
-
+  /// <summary>
   /// Describes an asset which should be assigned automatically.
+  /// </summary>
   [System.AttributeUsage (System.AttributeTargets.Field)]
   public class Asset : System.Attribute {
-
+    /// <summary>
     /// Defines whether the field name should be used for getting the asset from
     /// the controller. When set to false, the asset name string will be used
     /// instead.
-    private bool useFieldNameAsAssetName = false;
+    /// </summary>
+    bool useFieldNameAsAssetName = false;
 
+    /// <summary>
     /// The asset name will be used when defined that the field name should not
     /// be used for finding the asset name. Thus using this asset name property
     /// instead.
-    private string assetName = "";
+    /// </summary>
+    string assetName = "";
 
+    /// <summary>
     /// Defines the property as an asset, when the controller is done 
     /// registering, the asset will be fetched from the controller using the
     /// name of the property field.
+    /// </summary>
     public Asset () {
-      this.useFieldNameAsAssetName = true;
-      this.assetName = "";
+      useFieldNameAsAssetName = true;
+      assetName = "";
     }
 
+    /// <summary>
     /// Defines the property as an asset, when the controller is done 
     /// registering, the asset will be fetched from the controller using the
     /// given asset name.
-    public Asset(string assetName) {
-      this.useFieldNameAsAssetName = false;
+    /// </summary>
+    /// <param name="assetName">The asset name.</param>
+    public Asset (string assetName) {
+      useFieldNameAsAssetName = false;
       this.assetName = assetName;
     }
 
+    /// <summary>
     /// Sets the attributes values on an object.
+    /// </summary>
+    /// <param name="target">The target object.</param>
     public static void SetAttributeValues (System.Object target) {
-      var _fields = target.GetType ().GetFields (
-        System.Reflection.BindingFlags.Instance |
-        System.Reflection.BindingFlags.NonPublic);
-      foreach (var _field in _fields) {
-        var _assetFieldAttribute = System.Attribute.GetCustomAttribute (_field, typeof (Asset)) as Asset;
-        if (_assetFieldAttribute != null)
-          _field.SetValue (target, Controller.Instance.GetAsset(
-            _assetFieldAttribute.useFieldNameAsAssetName == true ? _field.Name : _assetFieldAttribute.assetName));
+      var targetType = target.GetType ();
+      var fields = targetType.GetFields (System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic);
+      foreach (var field in fields) {
+        var assetFieldAttribute = System.Attribute.GetCustomAttribute (field, typeof (Asset)) as Asset;
+        if (assetFieldAttribute == null) {
+          continue;
+        }
+        var assetName = assetFieldAttribute.useFieldNameAsAssetName ? field.Name : assetFieldAttribute.assetName;
+        var asset = Controller.Instance.GetAsset (assetName);
+        field.SetValue (target, asset);
       }
     }
   }

Runtime/Attributes/Injected.cs

@@ -1,24 +1,46 @@
 namespace ElRaccoone.EntityComponentSystem {
-
+  /// <summary>
   /// Describes a injectedable system, service or controller.
+  /// </summary>
   [System.AttributeUsage (System.AttributeTargets.Field)]
   public class Injected : System.Attribute {
+    /// <summary>
+    /// Type of an entity system.
+    /// </summary>
+    static readonly System.Type entitySystemType = typeof (IEntitySystem);
+
+    /// <summary>
+    /// Type of a service.
+    /// </summary>
+    static readonly System.Type serviceType = typeof (IService);
+
+    /// <summary>
+    /// Type of a controller.
+    /// </summary>
+    static readonly System.Type controllerType = typeof (IController);
 
+    /// <summary>
     /// Sets the attributes values on an object.
+    /// </summary>
+    /// <param name="target">The target object.</param>
     public static void SetAttributeValues (System.Object target) {
-      var _fields = target.GetType ().GetFields (
-        System.Reflection.BindingFlags.Instance |
-        System.Reflection.BindingFlags.NonPublic);
-      foreach (var _field in _fields)
-        if (System.Attribute.GetCustomAttribute (_field, typeof (Injected)) != null)
-          foreach (var _fieldInterface in _field.FieldType.GetInterfaces ()) {
-            if (_fieldInterface == typeof (IEntitySystem))
-              _field.SetValue (target, Controller.Instance.GetSystem (_field.FieldType));
-            else if (_fieldInterface == typeof (IService))
-              _field.SetValue (target, Controller.Instance.GetService (_field.FieldType));
-            else if (_fieldInterface == typeof (IController))
-              _field.SetValue (target, Controller.Instance);
+      var targetType = target.GetType ();
+      var fields = targetType.GetFields (System.Reflection.BindingFlags.Instance | System.Reflection.BindingFlags.NonPublic);
+      foreach (var field in fields) {
+        if (System.Attribute.GetCustomAttribute (field, typeof (Injected)) == null) {
+          continue;
+        }
+        var fieldInterfaces = field.FieldType.GetInterfaces ();
+        foreach (var fieldInterface in fieldInterfaces) {
+          if (fieldInterface == entitySystemType) {
+            field.SetValue (target, Controller.Instance.GetSystem (field.FieldType));
+          } else if (fieldInterface == serviceType) {
+            field.SetValue (target, Controller.Instance.GetService (field.FieldType));
+          } else if (fieldInterface == controllerType) {
+            field.SetValue (target, Controller.Instance);
           }
+        }
+      }
     }
   }
 }