You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat(lib): remove constraint on last animation and update readme (#117)
This removes the constraint that required a Slide class to end with a animation. This was actually not needed, and could lead to confusion since `self.wait` is not an animation with ManimGL, but well with Manim.
This fix, however, still means that a calls to `self.wait` with ManimGL, after last `self.pause` call, will be ignored.
> *Note:* the `-e` flag allows you to edit the files, and observe the changes directly when using Manim Slides
54
+
An alternative way to install Manim Slides is to clone the git repository, and install from there: read the [contributing guide](https://eertmans.be/manim-slides/contributing/workflow.html) to know how.
62
55
63
56
<!-- end install -->
64
57
@@ -97,14 +90,8 @@ class BasicExample(Slide):
97
90
98
91
self.play(dot.animate.move_to(ORIGIN))
99
92
self.pause() # Waits user to press continue to go to the next slide
100
-
101
-
# Each slide MUST end with an animation
102
-
# -> self.wait is considered an animation with Manim, not ManimGL
103
-
self.play(dot.animate.move_to(LEFT))
104
93
```
105
94
106
-
You **must** end your `Slide` with a `self.play(...)` or a `self.wait(...)`.
0 commit comments