Skip to content

Commit 5a3a799

Browse files
committed
don't try subclassing magicmock
1 parent 347f35f commit 5a3a799

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

pytest_flask_sqlalchemy/fixtures.py

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,8 @@ def _engine(pytestconfig, request, _transaction, mocker):
9393

9494
# Make sure that any attempts to call `connect()` simply return a
9595
# reference to the open connection
96-
class EngineMock(mocker.MagicMock):
97-
pass
9896

99-
engine = EngineMock(spec=sa.engine.Engine)
97+
engine = mocker.MagicMock(spec=sa.engine.Engine)
10098

10199
engine.connect.return_value = connection
102100

@@ -109,10 +107,10 @@ class EngineMock(mocker.MagicMock):
109107
engine._contextual_connect.return_value = connection
110108

111109
# Calls to execution_options should return this mocked engine.
112-
# engine.execution_options.return_value = engine
110+
engine.execution_options.return_value = engine
113111

114112
if version.parse(sa.__version__) >= version.parse('1.4'):
115-
sa.inspection._registrars[EngineMock] = sa.engine.Inspector._engine_insp
113+
sa.inspection._registrars[mocker.MagicMock] = sa.engine.Inspector._engine_insp
116114

117115
# References to `Engine.dialect` should redirect to the Connection (this
118116
# is primarily useful for the `autoload` flag in SQLAlchemy, which references

0 commit comments

Comments
 (0)