Skip to content
This repository was archived by the owner on Jul 2, 2024. It is now read-only.

Commit b0523df

Browse files
authored
Merge pull request #227 from jdeathe/issue/222
CLOSES #222: Updates php-hello-world app to 0.13.0.
2 parents eb15a32 + 574c176 commit b0523df

File tree

3 files changed

+16
-12
lines changed

3 files changed

+16
-12
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ Summary of release changes.
66

77
### 2.2.1 - Unreleased
88

9+
- Updates php-hello-world to [0.13.0](https://github.com/jdeathe/php-hello-world/releases/tag/0.13.0).
910
- Adds setting PHP `date.timezone` to `PHP_OPTIONS_DATE_TIMEZONE` into service configuration; removes dependency on app package configuration.
1011
- Adds session PHP settings into service configuration; removes dependency on app package configuration.
1112

Dockerfile

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ FROM jdeathe/centos-ssh:2.6.0
33
# Use the form ([{fqdn}-]{package-name}|[{fqdn}-]{provider-name})
44
ARG PACKAGE_NAME="app"
55
ARG PACKAGE_PATH="/opt/${PACKAGE_NAME}"
6-
ARG PACKAGE_RELEASE_VERSION="0.12.0"
6+
ARG PACKAGE_RELEASE_VERSION="0.13.0"
77
ARG RELEASE_VERSION="2.2.0"
88

99
# ------------------------------------------------------------------------------
@@ -47,9 +47,9 @@ ADD src /
4747
# - Disable Apache default fcgid configuration; replaced with 00-fcgid.conf
4848
# - Custom Apache configuration
4949
# - Disable all Apache modules and enable the minimum
50-
# - Disable SSL
5150
# - Disable the default SSL Virtual Host
52-
# - Global PHP configuration changes
51+
# - Disable SSL
52+
# - Add default PHP configuration overrides to 00-php.ini drop-in.
5353
# - Replace placeholders with values in systemd service unit template
5454
# - Set permissions
5555
# ------------------------------------------------------------------------------
@@ -215,9 +215,6 @@ RUN mkdir -p -m 750 ${PACKAGE_PATH} \
215215
&& mv \
216216
${PACKAGE_PATH}/public \
217217
${PACKAGE_PATH}/public_html \
218-
&& rm -f \
219-
${PACKAGE_PATH}/bin/php-wrapper \
220-
${PACKAGE_PATH}/etc/httpd/conf.d/50-fcgid.conf \
221218
&& $(\
222219
if [[ -f /usr/share/php-pecl-apc/apc.php ]]; then \
223220
cp \
@@ -228,8 +225,7 @@ RUN mkdir -p -m 750 ${PACKAGE_PATH} \
228225
&& chown -R app:app-www ${PACKAGE_PATH} \
229226
&& find ${PACKAGE_PATH} -type d -exec chmod 750 {} + \
230227
&& find ${PACKAGE_PATH}/var -type d -exec chmod 770 {} + \
231-
&& find ${PACKAGE_PATH} -type f -exec chmod 640 {} + \
232-
&& find ${PACKAGE_PATH}/bin -type f -exec chmod 750 {} +
228+
&& find ${PACKAGE_PATH} -type f -exec chmod 640 {} +
233229

234230
EXPOSE 80 443 8443
235231

src/usr/sbin/httpd-bootstrap

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1900,13 +1900,20 @@ function main ()
19001900
__enable_apache_modules
19011901
)"
19021902

1903-
# Set ownership for fcgid php-wrapper and socket if necessary
1904-
if [[ -d /var/run/mod_fcgid ]] \
1905-
&& [[ -d ${package_path}/bin ]]
1903+
# Set ownership for fcgid socket
1904+
if [[ -d /var/run/mod_fcgid ]]
19061905
then
19071906
chown -R \
19081907
"${apache_run_user}":"${apache_run_group}" \
1909-
{"${package_path}"/bin,/var/run/mod_fcgid}
1908+
/var/run/mod_fcgid
1909+
fi
1910+
1911+
# Set ownership for any package binaries
1912+
if [[ -d ${package_path}/bin ]]
1913+
then
1914+
chown -R \
1915+
"${apache_run_user}":"${apache_run_group}" \
1916+
"${package_path}"/bin
19101917
fi
19111918

19121919
__init_datadir \

0 commit comments

Comments
 (0)