From b7767ef1fe0784aed000dc74b3faae4fa503a6f6 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:24:16 +0200 Subject: [PATCH 01/16] nn --- .github/workflows/publish-npm.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index ace1fa2..0498b07 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -14,6 +14,7 @@ jobs: include: - { target: x86_64-apple-darwin, os: macos-latest } - { target: x86_64-unknown-linux-gnu, os: ubuntu-latest } + - { target: aarch64-apple-darwin, os: macos-latest } - { target: x86_64-pc-windows-msvc, os: windows-latest } runs-on: ${{ matrix.os }} steps: From 2ac47688ffb76dd20063a9949540cd17b536bc2b Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:24:37 +0200 Subject: [PATCH 02/16] nn --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 516d6a9..05626e5 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "type": "commonjs", - "name": "@bindrs/rfd", + "name": "@xmorse/rfd", "version": "2.2.2", "description": "📂 Lets you open native file picker and message boxes in JavaScript!", "keywords": [ From 1b117b30d38e8ea6b84f01df6d76bac0cde480ab Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:27:22 +0200 Subject: [PATCH 03/16] nn --- .github/workflows/publish-npm.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 0498b07..01e83de 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -1,7 +1,8 @@ name: Publish npm on: - release: - types: published + push: + branches: + - more-triplets workflow_dispatch: concurrency: group: ${{ github.workflow }} From 923e5174f6ec12e4802687dad2c0cab4d8d88c61 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:28:06 +0200 Subject: [PATCH 04/16] nn --- .github/workflows/publish-npm.yml | 2 +- Cargo.lock | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 01e83de..07d3d2a 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -19,7 +19,7 @@ jobs: - { target: x86_64-pc-windows-msvc, os: windows-latest } runs-on: ${{ matrix.os }} steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 - uses: actions/setup-node@v3 with: cache: npm diff --git a/Cargo.lock b/Cargo.lock index f3d6ee1..212aa51 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1,6 +1,6 @@ # This file is automatically @generated by Cargo. # It is not intended for manual editing. -version = 3 +version = 4 [[package]] name = "aho-corasick" @@ -710,7 +710,7 @@ dependencies = [ ] [[package]] -name = "rfd-node" +name = "rfd-js" version = "0.0.0" dependencies = [ "futures", From 18b757dfad5c7ffc68ba6e6e56e0c77a4c4f67e9 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:31:03 +0200 Subject: [PATCH 05/16] Update publish-npm.yml --- .github/workflows/publish-npm.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 07d3d2a..760249c 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -36,7 +36,7 @@ jobs: shell: bash env: TARGET: ${{ matrix.target }} - - uses: actions/upload-artifact@v3 + - uses: actions/upload-artifact@v4 with: name: ${{ matrix.target }} path: | From 523086664f0b6399ee4d8b93bbbdb0a636a8ce1e Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:31:15 +0200 Subject: [PATCH 06/16] Update publish-npm.yml --- .github/workflows/publish-npm.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 760249c..437ebcc 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -20,7 +20,7 @@ jobs: runs-on: ${{ matrix.os }} steps: - uses: actions/checkout@v4 - - uses: actions/setup-node@v3 + - uses: actions/setup-node@v4 with: cache: npm - run: rustup toolchain install stable -t "$TARGET" @@ -52,7 +52,7 @@ jobs: with: cache: npm registry-url: https://registry.npmjs.org/ - - uses: actions/download-artifact@v3 + - uses: actions/download-artifact@v4 with: path: artifacts - run: npm ci From e6054a6531fbbd7bc4a3d748d96bdae98dad0a11 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:35:50 +0200 Subject: [PATCH 07/16] nn --- package.json | 1 + 1 file changed, 1 insertion(+) diff --git a/package.json b/package.json index 05626e5..9d279f9 100644 --- a/package.json +++ b/package.json @@ -2,6 +2,7 @@ "type": "commonjs", "name": "@xmorse/rfd", "version": "2.2.2", + "private": false, "description": "📂 Lets you open native file picker and message boxes in JavaScript!", "keywords": [ "bindings", From 30ba50e5d05a47ccc42773eeebe43539e88f028c Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 17:36:16 +0200 Subject: [PATCH 08/16] Update package.json --- package.json | 3 +++ 1 file changed, 3 insertions(+) diff --git a/package.json b/package.json index 9d279f9..9cdbcd7 100644 --- a/package.json +++ b/package.json @@ -11,6 +11,9 @@ "nodejs-addon", "rust" ], + "publishConfig": { + "access": "public" + }, "license": "MIT", "contributors": [ "Jacob Hummer (https://jcbhmr.me/)" From 9214851a36365fe70b7c4e8e95162f2fd6f463e1 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 18:02:47 +0200 Subject: [PATCH 09/16] fix package json --- package.json | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 9cdbcd7..9532d1c 100644 --- a/package.json +++ b/package.json @@ -1,8 +1,10 @@ { "type": "commonjs", "name": "@xmorse/rfd", - "version": "2.2.2", + "version": "2.2.3", "private": false, + "main": "index.js", + "types": "index.d.ts", "description": "📂 Lets you open native file picker and message boxes in JavaScript!", "keywords": [ "bindings", From 5f78beca017cb50c6763018c48952ff642b57da2 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 18:08:04 +0200 Subject: [PATCH 10/16] types --- package.json | 17 +++++++++++++---- 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 9532d1c..e7a2622 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "type": "commonjs", "name": "@xmorse/rfd", - "version": "2.2.3", + "version": "2.2.4", "private": false, "main": "index.js", "types": "index.d.ts", @@ -24,9 +24,18 @@ "repository": "github:bindrs/rfd", "bugs": "https://github.com/bindrs/rfd/issues", "exports": { - "deno": "./index.js", - "bun": "./index.js", - "node-addons": "./index.js" + "deno": { + "types": "./index.d.ts", + "default": "./index.js" + }, + "bun": { + "types": "./index.d.ts", + "default": "./index.js" + }, + "node-addons": { + "types": "./index.d.ts", + "default": "./index.js" + } }, "files": [ "*.node", From 8e8093034e0447c0f944e4c90a5b82effe4b8b2d Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 18:17:12 +0200 Subject: [PATCH 11/16] fix types again!!! --- package.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package.json b/package.json index e7a2622..c104676 100644 --- a/package.json +++ b/package.json @@ -35,6 +35,10 @@ "node-addons": { "types": "./index.d.ts", "default": "./index.js" + }, + "default": { + "types": "./index.d.ts", + "default": "./index.js" } }, "files": [ From 697b47236bd16951c05219d714a205d98f48e9b2 Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 18:17:41 +0200 Subject: [PATCH 12/16] Update package.json --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index c104676..7d4d18b 100644 --- a/package.json +++ b/package.json @@ -36,7 +36,7 @@ "types": "./index.d.ts", "default": "./index.js" }, - "default": { + "node": { "types": "./index.d.ts", "default": "./index.js" } From 69df8d3e49a90c32fad40ef8ee0392d93c3bb1aa Mon Sep 17 00:00:00 2001 From: remorses Date: Tue, 9 Sep 2025 18:17:51 +0200 Subject: [PATCH 13/16] Update package.json --- package.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/package.json b/package.json index 7d4d18b..ee8e7ce 100644 --- a/package.json +++ b/package.json @@ -39,6 +39,10 @@ "node": { "types": "./index.d.ts", "default": "./index.js" + }, + "default": { + "types": "./index.d.ts", + "default": "./index.js" } }, "files": [ From af310e337919bfb58135105853d1ebea46bd2115 Mon Sep 17 00:00:00 2001 From: remorses Date: Wed, 10 Sep 2025 10:53:48 +0200 Subject: [PATCH 14/16] nn --- README.md | 9 +++++++++ package.json | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index ee0979f..2eeadda 100644 --- a/README.md +++ b/README.md @@ -99,6 +99,15 @@ if (answer) { also refer to the original [rfd crate documentation] if you want to learn more about the features and limitations inherited from the Rust API. +## Known Limitations + +### Focus Issues + +File dialogs may not always appear focused or on top of other windows. This is a known limitation of the underlying `rfd` crate. For better focus behavior: + +- Use synchronous dialogs (`FileDialog`, `MessageDialog`) instead of async ones when possible +- See [FOCUS_NOTES.md](./FOCUS_NOTES.md) for detailed information and platform-specific workarounds + ## Development ![Rust](https://img.shields.io/static/v1?style=for-the-badge&message=Rust&color=000000&logo=Rust&logoColor=FFFFFF&label=) diff --git a/package.json b/package.json index ee8e7ce..eb1f53f 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "type": "commonjs", "name": "@xmorse/rfd", - "version": "2.2.4", + "version": "2.2.5", "private": false, "main": "index.js", "types": "index.d.ts", From 8a121eccecad4b35786046c551a88cfe487548e0 Mon Sep 17 00:00:00 2001 From: remorses Date: Wed, 10 Sep 2025 12:48:04 +0200 Subject: [PATCH 15/16] less changes --- .github/workflows/publish-npm.yml | 5 ++--- README.md | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/.github/workflows/publish-npm.yml b/.github/workflows/publish-npm.yml index 437ebcc..dc0adcb 100644 --- a/.github/workflows/publish-npm.yml +++ b/.github/workflows/publish-npm.yml @@ -1,8 +1,7 @@ name: Publish npm on: - push: - branches: - - more-triplets + release: + types: published workflow_dispatch: concurrency: group: ${{ github.workflow }} diff --git a/README.md b/README.md index 2eeadda..799bfdb 100644 --- a/README.md +++ b/README.md @@ -106,7 +106,6 @@ about the features and limitations inherited from the Rust API. File dialogs may not always appear focused or on top of other windows. This is a known limitation of the underlying `rfd` crate. For better focus behavior: - Use synchronous dialogs (`FileDialog`, `MessageDialog`) instead of async ones when possible -- See [FOCUS_NOTES.md](./FOCUS_NOTES.md) for detailed information and platform-specific workarounds ## Development From 6884842763867f44d41930fa38a6f9fc08e1bf53 Mon Sep 17 00:00:00 2001 From: remorses Date: Wed, 10 Sep 2025 12:48:40 +0200 Subject: [PATCH 16/16] Update package.json --- package.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package.json b/package.json index eb1f53f..f6c3de9 100644 --- a/package.json +++ b/package.json @@ -1,7 +1,7 @@ { "type": "commonjs", - "name": "@xmorse/rfd", - "version": "2.2.5", + "name": "@bindrs/rfd", + "version": "2.2.3", "private": false, "main": "index.js", "types": "index.d.ts",