Improve appraisal config

Author: n-rodriguez

Appraisals

@@ -1,34 +1,27 @@
 # frozen_string_literal: true
 
-RAILS_VERSIONS = {
-  '5.2.4' => {
-    'activerecord-oracle_enhanced-adapter' => '~> 5.2.0',
-    'sqlite3' => '~> 1.3.0',
-    'mysql2' => '',
-    'ruby-oci8' => '',
-  },
-  '6.0.3' => {
-    'activerecord-oracle_enhanced-adapter' => '~> 6.0.0',
-    'sqlite3' => '~> 1.4.0',
-    'mysql2' => '',
-    'ruby-oci8' => '',
-  },
-  '6.1.0' => {
-    'activerecord-oracle_enhanced-adapter' => '~> 6.1.0',
-    'sqlite3' => '~> 1.4.0',
-    'mysql2' => '',
-    'ruby-oci8' => '',
-  },
-}.freeze
+require 'yaml'
 
-RAILS_VERSIONS.each do |version, gems|
+rails_versions = YAML.load(File.read('appraisal.yml'))
+
+rails_versions.each do |version, gems|
   appraise "rails_#{version}" do
     gem 'rails', version
-    gems.each do |name, gem_version|
-      if gem_version.empty?
-        gem name
+    gems.each do |name, opts|
+      if opts['install_if']
+        install_if opts['install_if'] do
+          if opts['version'].empty?
+            gem name
+          else
+            gem name, opts['version']
+          end
+        end
       else
-        gem name, gem_version
+        if opts['version'].empty?
+          gem name
+        else
+          gem name, opts['version']
+        end
       end
     end
   end

Gemfile

@@ -3,3 +3,5 @@
 source 'https://rubygems.org'
 
 gemspec
+
+gem 'appraisal', git: 'https://github.com/thoughtbot/appraisal.git'

appraisal.yml

@@ -0,0 +1,42 @@
+---
+5.2.4:
+  sqlite3:
+    version: ~> 1.3.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "sqlite3" }'
+  mysql2:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "mysql2" }'
+  activerecord-oracle_enhanced-adapter:
+    version: ~> 5.2.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'
+  ruby-oci8:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'
+
+6.0.3:
+  sqlite3:
+    version: ~> 1.4.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "sqlite3" }'
+  mysql2:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "mysql2" }'
+  activerecord-oracle_enhanced-adapter:
+    version: ~> 6.0.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'
+  ruby-oci8:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'
+
+6.1.0:
+  sqlite3:
+    version: ~> 1.4.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "sqlite3" }'
+  mysql2:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "mysql2" }'
+  activerecord-oracle_enhanced-adapter:
+    version: ~> 6.1.0
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'
+  ruby-oci8:
+    version: ''
+    install_if: '-> { ENV["DB_ADAPTER"] == "oracle_enhanced" }'

gemfiles/rails_5.2.4.gemfile

@@ -2,10 +2,20 @@
 
 source "https://rubygems.org"
 
+gem "appraisal", git: "https://github.com/n-rodriguez/appraisal.git", branch: "wip/install_if"
 gem "rails", "5.2.4"
-gem "activerecord-oracle_enhanced-adapter", "~> 5.2.0"
-gem "sqlite3", "~> 1.3.0"
-gem "mysql2"
-gem "ruby-oci8" if ENV["DB_ADAPTER"] == "oracle_enhanced"
+
+install_if -> { ENV["DB_ADAPTER"] == "sqlite3" } do
+  gem "sqlite3", "~> 1.3.0"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "mysql2" } do
+  gem "mysql2"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "oracle_enhanced" } do
+  gem "activerecord-oracle_enhanced-adapter", "~> 5.2.0"
+  gem "ruby-oci8"
+end
 
 gemspec path: "../"

gemfiles/rails_6.0.3.gemfile

@@ -2,10 +2,20 @@
 
 source "https://rubygems.org"
 
+gem "appraisal", git: "https://github.com/n-rodriguez/appraisal.git", branch: "wip/install_if"
 gem "rails", "6.0.3"
-gem "activerecord-oracle_enhanced-adapter", "~> 6.0.0"
-gem "sqlite3", "~> 1.4.0"
-gem "mysql2"
-gem "ruby-oci8" if ENV["DB_ADAPTER"] == "oracle_enhanced"
+
+install_if -> { ENV["DB_ADAPTER"] == "sqlite3" } do
+  gem "sqlite3", "~> 1.4.0"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "mysql2" } do
+  gem "mysql2"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "oracle_enhanced" } do
+  gem "activerecord-oracle_enhanced-adapter", "~> 6.0.0"
+  gem "ruby-oci8"
+end
 
 gemspec path: "../"

gemfiles/rails_6.1.0.gemfile

@@ -2,10 +2,20 @@
 
 source "https://rubygems.org"
 
+gem "appraisal", git: "https://github.com/n-rodriguez/appraisal.git", branch: "wip/install_if"
 gem "rails", "6.1.0"
-gem "activerecord-oracle_enhanced-adapter", "~> 6.1.0"
-gem "sqlite3", "~> 1.4.0"
-gem "mysql2"
-gem "ruby-oci8" if ENV["DB_ADAPTER"] == "oracle_enhanced"
+
+install_if -> { ENV["DB_ADAPTER"] == "sqlite3" } do
+  gem "sqlite3", "~> 1.4.0"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "mysql2" } do
+  gem "mysql2"
+end
+
+install_if -> { ENV["DB_ADAPTER"] == "oracle_enhanced" } do
+  gem "activerecord-oracle_enhanced-adapter", "~> 6.1.0"
+  gem "ruby-oci8"
+end
 
 gemspec path: "../"