Remove dependency on view_context module, only inject request params

Author: n-rodriguez

README.md

@@ -317,7 +317,7 @@ Set the controller to respond to JSON
 def index
   respond_to do |format|
     format.html
-    format.json { render json: UserDatatable.new(view_context) }
+    format.json { render json: UserDatatable.new(params) }
   end
 end
 ```
@@ -386,7 +386,9 @@ Sometimes you'll need to use view helper methods like `link_to`, `mail_to`,
 To have these methods available to be used, this is the way to go:
 
 ```ruby
-class MyCustomDatatable < AjaxDatatablesRails::Base
+class UserDatatable < AjaxDatatablesRails::Base
+  extend Forwardable
+
   # either define them one-by-one
   def_delegator :@view, :check_box_tag
   def_delegator :@view, :link_to
@@ -398,6 +400,11 @@ class MyCustomDatatable < AjaxDatatablesRails::Base
 
   # ... other methods (view_columns, get_raw_records...)
 
+  def initialize(params, opts = {})
+    @view = opts[:view_context]
+    super
+  end
+
   # now, you'll have these methods available to be used anywhere
   def data
     records.map do |record|
@@ -412,6 +419,14 @@ class MyCustomDatatable < AjaxDatatablesRails::Base
     end
   end
 end
+
+# and in your controller:
+def index
+  respond_to do |format|
+    format.html
+    format.json { render json: UserDatatable.new(params, view_context: view_context) }
+  end
+end
 ```
 
 ### Using view decorators
@@ -464,12 +479,7 @@ class UserDecorator < ApplicationDecorator
 end
 ```
 
-**Note :** On the long term it's much more cleaner than using `def_delegator` since decorators are reusable everywhere in your application :)
-
-So we **strongly recommand you to use Draper decorators.** It will help keeping your DataTables class small and clean and keep focused on what they should do (mostly) : filtering records ;)
-
-**Note 2 :** The `def_delegator` might disappear in a near future : [#288 [RFC] Remove dependency on view_context](https://github.com/jbox-web/ajax-datatables-rails/issues/288).
-You're invited to give your opinion :)
+This way you don't need to inject the `view_context` in the Datatable object to access helpers methods.
 
 ### Pass options to the datatable class
 
@@ -482,7 +492,7 @@ Example:
 def index
   respond_to do |format|
     format.html
-    format.json { render json: UserDatatable.new(view_context, user: current_user, from: 1.month.ago) }
+    format.json { render json: UserDatatable.new(params, user: current_user, from: 1.month.ago) }
   end
 end
 
@@ -728,15 +738,15 @@ then in your controllers :
   end
 
   def datatable
-    render json: PostDatatable.new(view_context)
+    render json: PostDatatable.new(params)
   end
 
 # UsersController
   def index
   end
 
   def datatable
-    render json: UserDatatable.new(view_context)
+    render json: UserDatatable.new(params)
   end
 ```
 

lib/ajax-datatables-rails/base.rb

@@ -2,15 +2,13 @@
 
 module AjaxDatatablesRails
   class Base
-    extend Forwardable
 
-    attr_reader :view, :options
-    def_delegator :@view, :params
+    attr_reader :params, :options
 
     GLOBAL_SEARCH_DELIMITER = ' '
 
-    def initialize(view, options = {})
-      @view    = view
+    def initialize(params, options = {})
+      @params  = params
       @options = options
       load_orm_extension
     end

spec/ajax-datatables-rails/base_spec.rb

@@ -3,50 +3,46 @@
 describe AjaxDatatablesRails::Base do
 
   describe 'an instance' do
-    let(:view) { double('view', params: sample_params) }
-
-    it 'requires a view_context' do
+    it 'requires a hash of params' do
       expect { described_class.new }.to raise_error ArgumentError
     end
 
     it 'accepts an options hash' do
-      datatable = described_class.new(view, foo: 'bar')
+      datatable = described_class.new(sample_params, foo: 'bar')
       expect(datatable.options).to eq(foo: 'bar')
     end
   end
 
   context 'Public API' do
-    let(:view) { double('view', params: sample_params) }
-
     describe '#view_columns' do
       it 'raises an error if not defined by the user' do
-        datatable = described_class.new(view)
+        datatable = described_class.new(sample_params)
         expect { datatable.view_columns }.to raise_error NotImplementedError
       end
 
       context 'child class implements view_columns' do
         it 'expects a hash based defining columns' do
-          datatable = ComplexDatatable.new(view)
+          datatable = ComplexDatatable.new(sample_params)
           expect(datatable.view_columns).to be_a(Hash)
         end
       end
     end
 
     describe '#get_raw_records' do
       it 'raises an error if not defined by the user' do
-        datatable = described_class.new(view)
+        datatable = described_class.new(sample_params)
         expect { datatable.get_raw_records }.to raise_error NotImplementedError
       end
     end
 
     describe '#data' do
       it 'raises an error if not defined by the user' do
-        datatable = described_class.new(view)
+        datatable = described_class.new(sample_params)
         expect { datatable.data }.to raise_error NotImplementedError
       end
 
       context 'when data is defined as a hash' do
-        let(:datatable) { ComplexDatatable.new(view) }
+        let(:datatable) { ComplexDatatable.new(sample_params) }
 
         it 'should return an array of hashes' do
           create_list(:user, 5)
@@ -66,7 +62,7 @@
       end
 
       context 'when data is defined as a array' do
-        let(:datatable) { ComplexDatatableArray.new(view) }
+        let(:datatable) { ComplexDatatableArray.new(sample_params) }
 
         it 'should return an array of arrays' do
           create_list(:user, 5)
@@ -87,7 +83,7 @@
     end
 
     describe '#as_json' do
-      let(:datatable) { ComplexDatatable.new(view) }
+      let(:datatable) { ComplexDatatable.new(sample_params) }
 
       it 'should return a hash' do
         create_list(:user, 5)
@@ -116,8 +112,7 @@
 
   context 'Private API' do
 
-    let(:view) { double('view', params: sample_params) }
-    let(:datatable) { ComplexDatatable.new(view) }
+    let(:datatable) { ComplexDatatable.new(sample_params) }
 
     before(:each) do
       allow_any_instance_of(AjaxDatatablesRails::Configuration).to receive(:orm) { nil }
@@ -150,34 +145,31 @@
     describe 'helper methods' do
       describe '#offset' do
         it 'defaults to 0' do
-          default_view = double('view', params: {})
-          datatable = described_class.new(default_view)
+          datatable = described_class.new({})
           expect(datatable.datatable.send(:offset)).to eq(0)
         end
 
         it 'matches the value on view params[:start]' do
-          paginated_view = double('view', params: { start: '11' })
-          datatable = described_class.new(paginated_view)
+          datatable = described_class.new({ start: '11' })
           expect(datatable.datatable.send(:offset)).to eq(11)
         end
       end
 
       describe '#page' do
         it 'calculates page number from params[:start] and #per_page' do
-          paginated_view = double('view', params: { start: '11' })
-          datatable = described_class.new(paginated_view)
+          datatable = described_class.new({ start: '11' })
           expect(datatable.datatable.send(:page)).to eq(2)
         end
       end
 
       describe '#per_page' do
         it 'defaults to 10' do
-          datatable = described_class.new(view)
+          datatable = described_class.new(sample_params)
           expect(datatable.datatable.send(:per_page)).to eq(10)
         end
 
         it 'matches the value on view params[:length]' do
-          other_view = double('view', params: { length: 20 })
+          other_view = { length: 20 }
           datatable = described_class.new(other_view)
           expect(datatable.datatable.send(:per_page)).to eq(20)
         end

spec/ajax-datatables-rails/datatable/column_spec.rb

@@ -2,8 +2,7 @@
 
 describe AjaxDatatablesRails::Datatable::Column do
 
-  let(:view) { double('view', params: sample_params) }
-  let(:datatable) { ComplexDatatable.new(view) }
+  let(:datatable) { ComplexDatatable.new(sample_params) }
 
   describe 'username column' do
 
@@ -129,7 +128,7 @@
   end
 
   describe '#formatter' do
-    let(:datatable) { DatatableWithFormater.new(view) }
+    let(:datatable) { DatatableWithFormater.new(sample_params) }
     let(:column) { datatable.datatable.columns.find { |c| c.data == 'last_name' } }
 
     it 'should be a proc' do
@@ -138,7 +137,7 @@
   end
 
   describe '#filter' do
-    let(:datatable) { DatatableCondProc.new(view) }
+    let(:datatable) { DatatableCondProc.new(sample_params) }
     let(:column) { datatable.datatable.columns.find { |c| c.data == 'username' } }
 
     it 'should be a proc' do

spec/ajax-datatables-rails/datatable/datatable_spec.rb

@@ -2,8 +2,7 @@
 
 describe AjaxDatatablesRails::Datatable::Datatable do
 
-  let(:view) { double('view', params: sample_params) }
-  let(:datatable) { ComplexDatatable.new(view).datatable }
+  let(:datatable) { ComplexDatatable.new(sample_params).datatable }
   let(:order_option) { {'0'=>{'column'=>'0', 'dir'=>'asc'}, '1'=>{'column'=>'1', 'dir'=>'desc'}} }
 
   describe 'order methods' do

spec/ajax-datatables-rails/datatable/simple_order_spec.rb

@@ -2,8 +2,7 @@
 
 describe AjaxDatatablesRails::Datatable::SimpleOrder do
 
-  let(:view) { double('view', params: sample_params) }
-  let(:datatable) { ComplexDatatable.new(view).datatable }
+  let(:datatable) { ComplexDatatable.new(sample_params).datatable }
   let(:options) { ActiveSupport::HashWithIndifferentAccess.new({'column' => '1', 'dir' => 'desc'}) }
   let(:simple_order) { AjaxDatatablesRails::Datatable::SimpleOrder.new(datatable, options) }
 
@@ -26,7 +25,7 @@
     end
 
     describe 'using column option' do
-      let(:sorted_datatable) { DatatableOrderNullsLast.new(view).datatable }
+      let(:sorted_datatable) { DatatableOrderNullsLast.new(sample_params).datatable }
       let(:nulls_last_order) { AjaxDatatablesRails::Datatable::SimpleOrder.new(sorted_datatable, options) }
 
       it 'sql query' do

spec/ajax-datatables-rails/extended_spec.rb

@@ -2,8 +2,7 @@
 
 describe AjaxDatatablesRails::Base do
   describe 'it can transform search value before asking the database' do
-    let(:view) { double('view', params: sample_params) }
-    let(:datatable) { DatatableWithFormater.new(view) }
+    let(:datatable) { DatatableWithFormater.new(sample_params) }
 
     before(:each) do
       create(:user, username: 'johndoe', email: 'johndoe@example.com', last_name: 'DOE')