Improve tests on AjaxDatatablesRails::Base

Author: n-rodriguez

lib/ajax-datatables-rails/base.rb

@@ -28,6 +28,23 @@ def data
       raise(NotImplementedError, data_error_text)
     end
 
+    # ORM defined methods
+    def fetch_records
+      get_raw_records
+    end
+
+    def filter_records(records)
+      raise(NotImplementedError)
+    end
+
+    def sort_records(records)
+      raise(NotImplementedError)
+    end
+
+    def paginate_records(records)
+      raise(NotImplementedError)
+    end
+
     # User overides
     def additional_data
       {}

lib/ajax-datatables-rails/orm/active_record.rb

@@ -4,10 +4,6 @@ module AjaxDatatablesRails
   module ORM
     module ActiveRecord
 
-      def fetch_records
-        get_raw_records
-      end
-
       def filter_records(records)
         records.where(build_conditions)
       end

spec/ajax-datatables-rails/base_spec.rb

@@ -84,54 +84,70 @@
   end
 
   describe 'ORM API' do
-    describe '#filter_records' do
-      let(:records) { User.all }
+    context 'when ORM is not implemented' do
+      let(:datatable) { AjaxDatatablesRails::Base.new(sample_params) }
 
-      let(:datatable) do
-        datatable = Class.new(ComplexDatatable) do
-          def filter_records(records)
-            raise NotImplementedError
-          end
+      describe '#fetch_records' do
+        it 'raises an error if it does not include an ORM module' do
+          expect { datatable.fetch_records }.to raise_error NotImplementedError
         end
-        datatable.new(sample_params)
       end
 
-      it 'should allow method override' do
-        expect { datatable.filter_records(records) }.to raise_error(NotImplementedError)
+      describe '#filter_records' do
+        it 'raises an error if it does not include an ORM module' do
+          expect { datatable.filter_records([]) }.to raise_error NotImplementedError
+        end
       end
-    end
-
-    describe '#sort_records' do
-      let(:records) { User.all }
 
-      let(:datatable) do
-        datatable = Class.new(ComplexDatatable) do
-          def sort_records(records)
-            raise NotImplementedError
-          end
+      describe '#sort_records' do
+        it 'raises an error if it does not include an ORM module' do
+          expect { datatable.sort_records([]) }.to raise_error NotImplementedError
         end
-        datatable.new(sample_params)
       end
 
-      it 'should allow method override' do
-        expect { datatable.sort_records(records) }.to raise_error(NotImplementedError)
+      describe '#paginate_records' do
+        it 'raises an error if it does not include an ORM module' do
+          expect { datatable.paginate_records([]) }.to raise_error NotImplementedError
+        end
       end
     end
 
-    describe '#paginate_records' do
-      let(:records) { User.all }
-
-      let(:datatable) do
-        datatable = Class.new(ComplexDatatable) do
-          def paginate_records(records)
-            raise NotImplementedError
+    context 'when ORM is implemented' do
+      describe 'it allows method override' do
+        let(:datatable) do
+          datatable = Class.new(ComplexDatatable) do
+            def filter_records(records)
+              raise NotImplementedError.new('FOO')
+            end
+
+            def sort_records(records)
+              raise NotImplementedError.new('FOO')
+            end
+
+            def paginate_records(records)
+              raise NotImplementedError.new('FOO')
+            end
           end
+          datatable.new(sample_params)
         end
-        datatable.new(sample_params)
-      end
 
-      it 'should allow method override' do
-        expect { datatable.paginate_records(records) }.to raise_error(NotImplementedError)
+        describe '#filter_records' do
+          it {
+            expect { datatable.filter_records([]) }.to raise_error(NotImplementedError).with_message('FOO')
+          }
+        end
+
+        describe '#sort_records' do
+          it {
+            expect { datatable.sort_records([]) }.to raise_error(NotImplementedError).with_message('FOO')
+          }
+        end
+
+        describe '#paginate_records' do
+          it {
+            expect { datatable.paginate_records([]) }.to raise_error(NotImplementedError).with_message('FOO')
+          }
+        end
       end
     end
   end
@@ -164,36 +180,6 @@ def paginate_records(records)
     end
   end
 
-  context 'Private API' do
-    context 'when orm is not implemented' do
-      let(:datatable) { AjaxDatatablesRails::Base.new(sample_params) }
-
-      describe '#fetch_records' do
-        it 'raises an error if it does not include an ORM module' do
-          expect { datatable.fetch_records }.to raise_error NoMethodError
-        end
-      end
-
-      describe '#filter_records' do
-        it 'raises an error if it does not include an ORM module' do
-          expect { datatable.filter_records }.to raise_error NoMethodError
-        end
-      end
-
-      describe '#sort_records' do
-        it 'raises an error if it does not include an ORM module' do
-          expect { datatable.sort_records }.to raise_error NoMethodError
-        end
-      end
-
-      describe '#paginate_records' do
-        it 'raises an error if it does not include an ORM module' do
-          expect { datatable.paginate_records }.to raise_error NoMethodError
-        end
-      end
-    end
-  end
-
   describe 'User helper methods' do
     describe '#column_id' do
       let(:datatable) { ComplexDatatable.new(sample_params) }