Coding style

Author: n-rodriguez

.rubocop.yml

@@ -1,6 +1,7 @@
 AllCops:
   TargetRubyVersion: 2.5
   Exclude:
+    - gemfiles/*
     - spec/**/*.rb
     - lib/ajax-datatables-rails.rb
     - lib/generators/rails/templates/*.rb

ajax-datatables-rails.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-$LOAD_PATH.push File.expand_path('../lib', __FILE__)
+$LOAD_PATH.push File.expand_path('lib', __dir__)
 require 'ajax-datatables-rails/version'
 
 Gem::Specification.new do |s|

lib/ajax-datatables-rails/base.rb

@@ -32,9 +32,9 @@ def additional_data
 
     def as_json(*)
       {
-        recordsTotal: records_total_count,
+        recordsTotal:    records_total_count,
         recordsFiltered: records_filtered_count,
-        data: sanitize(data)
+        data:            sanitize(data)
       }.merge(get_additional_data)
     end
 

lib/ajax-datatables-rails/datatable/column/search.rb

@@ -5,8 +5,8 @@ module Datatable
     class Column
       module Search
 
-        SMALLEST_PQ_INTEGER = -2147483648
-        LARGEST_PQ_INTEGER  = 2147483647
+        SMALLEST_PQ_INTEGER = -2_147_483_648
+        LARGEST_PQ_INTEGER  = 2_147_483_647
         NOT_NULL_VALUE      = '!NULL'
         EMPTY_VALUE         = ''
 
@@ -54,12 +54,13 @@ def regex_search
           end
         end
 
+        # rubocop:disable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity
         def non_regex_search
           case cond
           when Proc
             filter
           when :eq, :not_eq, :lt, :gt, :lteq, :gteq, :in
-            is_searchable_integer? ? raw_search(cond) : empty_search
+            searchable_integer? ? raw_search(cond) : empty_search
           when :null_value
             null_value_search
           when :start_with
@@ -74,6 +75,7 @@ def non_regex_search
             date_range_search
           end
         end
+        # rubocop:enable Metrics/MethodLength, Metrics/AbcSize, Metrics/CyclomaticComplexity
 
         def null_value_search
           if formatted_value == NOT_NULL_VALUE
@@ -95,21 +97,24 @@ def empty_search
           casted_column.matches(EMPTY_VALUE)
         end
 
-        def is_searchable_integer?
+        def searchable_integer?
           if formatted_value.is_a?(Array)
-            valids = formatted_value.map { |v| is_integer?(v) && !is_out_of_range?(v) }
+            valids = formatted_value.map { |v| integer?(v) && !out_of_range?(v) }
             !valids.include?(false)
           else
-            is_integer?(formatted_value) && !is_out_of_range?(formatted_value)
+            integer?(formatted_value) && !out_of_range?(formatted_value)
           end
         end
 
-        def is_out_of_range?(search_value)
+        def out_of_range?(search_value)
           Integer(search_value) > LARGEST_PQ_INTEGER || Integer(search_value) < SMALLEST_PQ_INTEGER
         end
 
-        def is_integer?(string)
-          true if Integer(string) rescue false
+        def integer?(string)
+          Integer(string)
+          true
+        rescue ArgumentError
+          false
         end
 
       end

lib/generators/datatable/config_generator.rb

@@ -6,10 +6,10 @@ module Datatable
   module Generators
     class ConfigGenerator < ::Rails::Generators::Base
       source_root File.expand_path(File.join(File.dirname(__FILE__), 'templates'))
-      desc <<DESC
-Description:
-  Creates an initializer file for AjaxDatatablesRails configuration at config/initializers.
-DESC
+      desc <<~DESC
+        Description:
+          Creates an initializer file for AjaxDatatablesRails configuration at config/initializers.
+      DESC
 
       def copy_config_file
         template 'ajax_datatables_rails_config.rb', 'config/initializers/ajax_datatables_rails.rb'