-
-
Notifications
You must be signed in to change notification settings - Fork 631
Open
Description
The implementation with firebase SDK has changed the output of the send_message method
Before it was a dict
django-push-notifications/push_notifications/gcm.py
Lines 202 to 204 in 7d28052
| return ret[0] if len(ret) == 1 else ret | |
| else: | |
| return _cm_send_request(None, data, cloud_type=cloud_type, **kwargs) |
Now it is a BatchResponse
django-push-notifications/push_notifications/gcm.py
Lines 188 to 190 in 0f79181
| return messaging.BatchResponse(ret) | |
| else: | |
| return messaging.BatchResponse([]) |
This means that any code which relies on the output to be a dict now need to work-around the new type.
This is a breaking change which should have been highlighted or avoided.
Metadata
Metadata
Assignees
Labels
No labels