Skip to content

Commit 0adb584

Browse files
superbobryGoogle-ML-Automation
authored andcommitted
Marked the parameters of safe_zip, safe_map and foreach as positional-only
This matches the signature of the original builtins as well as the impl in jaxlib/utils.cc PiperOrigin-RevId: 836249444
1 parent 7b052da commit 0adb584

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

jax/_src/util.py

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -50,13 +50,13 @@
5050
# to that used for builtins.zip in python/typeshed. This supports
5151
# return types matching input types for up to three arguments.
5252
@overload
53-
def safe_zip(__arg1: Iterable[T1]) -> list[tuple[T1]]: ...
53+
def safe_zip(__arg1: Iterable[T1], /) -> list[tuple[T1]]: ...
5454
@overload
55-
def safe_zip(__arg1: Iterable[T1], __arg2: Iterable[T2]) -> list[tuple[T1, T2]]: ...
55+
def safe_zip(__arg1: Iterable[T1], __arg2: Iterable[T2], /) -> list[tuple[T1, T2]]: ...
5656
@overload
57-
def safe_zip(__arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3]) -> list[tuple[T1, T2, T3]]: ...
57+
def safe_zip(__arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3], /) -> list[tuple[T1, T2, T3]]: ...
5858
@overload
59-
def safe_zip(__arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], *args) -> list[tuple[Any, ...]]: ...
59+
def safe_zip(__arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], /, *args) -> list[tuple[Any, ...]]: ...
6060

6161
def safe_zip(*args):
6262
"""
@@ -81,16 +81,16 @@ def safe_zip(*args):
8181
# to that used for builtins.map in python/typeshed. This supports
8282
# checking input types for the callable with up to three arguments.
8383
@overload
84-
def safe_map(f: Callable[[T1], T], __arg1: Iterable[T1]) -> list[T]: ...
84+
def safe_map(f: Callable[[T1], T], __arg1: Iterable[T1], /) -> list[T]: ...
8585

8686
@overload
87-
def safe_map(f: Callable[[T1, T2], T], __arg1: Iterable[T1], __arg2: Iterable[T2]) -> list[T]: ...
87+
def safe_map(f: Callable[[T1, T2], T], __arg1: Iterable[T1], __arg2: Iterable[T2], /) -> list[T]: ...
8888

8989
@overload
90-
def safe_map(f: Callable[[T1, T2, T3], T], __arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3]) -> list[T]: ...
90+
def safe_map(f: Callable[[T1, T2, T3], T], __arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3], /) -> list[T]: ...
9191

9292
@overload
93-
def safe_map(f: Callable[..., T], __arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], *args) -> list[T]: ...
93+
def safe_map(f: Callable[..., T], __arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], /, *args) -> list[T]: ...
9494

9595
def safe_map(f, *args):
9696
args = list(map(list, args))
@@ -104,16 +104,16 @@ def safe_map(f, *args):
104104

105105
if TYPE_CHECKING:
106106
@overload
107-
def foreach(f: Callable[[T1], Any], __arg1: Iterable[T1]) -> None: ...
107+
def foreach(f: Callable[[T1], Any], __arg1: Iterable[T1], /) -> None: ...
108108

109109
@overload
110-
def foreach(f: Callable[[T1, T2], Any], __arg1: Iterable[T1], __arg2: Iterable[T2]) -> None: ...
110+
def foreach(f: Callable[[T1, T2], Any], __arg1: Iterable[T1], __arg2: Iterable[T2], /) -> None: ...
111111

112112
@overload
113-
def foreach(f: Callable[[T1, T2, T3], Any], __arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3]) -> None: ...
113+
def foreach(f: Callable[[T1, T2, T3], Any], __arg1: Iterable[T1], __arg2: Iterable[T2], __arg3: Iterable[T3], /) -> None: ...
114114

115115
@overload
116-
def foreach(f: Callable[..., Any], __arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], *args) -> None: ...
116+
def foreach(f: Callable[..., Any], __arg1: Iterable[Any], __arg2: Iterable[Any], __arg3: Iterable[Any], __arg4: Iterable[Any], /, *args) -> None: ...
117117

118118
def foreach(f, *args):
119119
safe_map(f, *args)

0 commit comments

Comments
 (0)