fix warning due to finalName is a read-only property

Author: fvarrui

src/main/java/io/github/fvarrui/javapackager/maven/CreateTarball.java

@@ -35,8 +35,6 @@ public boolean skip(Packager packager) {
 	protected File doApply(Packager packager) {
 
 		File assetsFolder = packager.getAssetsFolder();
-		String name = packager.getName();
-		String version = packager.getVersion();
 		Platform platform = packager.getPlatform();
 		File outputDirectory = packager.getOutputDirectory(); 
 
@@ -46,8 +44,7 @@ protected File doApply(Packager packager) {
 			File assemblyFile = new File(assetsFolder, "assembly-tarball-" + platform + ".xml");
 			VelocityUtils.render(platform + "/assembly.xml.vtl", assemblyFile, packager);
 
-			// tgz file name
-			String finalName = packager.getTarballName() != null ? packager.getTarballName() : name + "-" + version + "-" + platform;
+			// output file format
 			String format = "tar.gz";
 
 			// invokes plugin to assemble tarball
@@ -62,13 +59,23 @@ protected File doApply(Packager packager) {
 							element("outputDirectory", outputDirectory.getAbsolutePath()),
 							element("formats", element("format", format)),
 							element("descriptors", element("descriptor", assemblyFile.getAbsolutePath())),
-							element("finalName", finalName),
 							element("appendAssemblyId", "false")
 					),
 					Context.getMavenContext().getEnv()
 				);
 
-			return new File(outputDirectory, finalName + "." + format); 
+			// get generated filename
+			String finalName = Context.getMavenContext().getEnv().getMavenProject().getBuild().getFinalName();
+			File finalFile = new File(outputDirectory, finalName + "." + format);
+
+			// get desired file name
+			String tarName = packager.getTarballName() != null ? packager.getTarballName() : finalName + "-" + platform;
+			File tarFile = new File(outputDirectory, tarName + "." + format);
+			
+			// rename generated to desired
+			finalFile.renameTo(tarFile);
+			
+			return tarFile;
 
 		} catch (Exception e) {
 

src/main/java/io/github/fvarrui/javapackager/maven/CreateZipball.java

@@ -35,8 +35,6 @@ public boolean skip(Packager packager) {
 	protected File doApply(Packager packager) {
 
 		File assetsFolder = packager.getAssetsFolder();
-		String name = packager.getName();
-		String version = packager.getVersion();
 		Platform platform = packager.getPlatform();
 		File outputDirectory = packager.getOutputDirectory(); 
 
@@ -47,7 +45,6 @@ protected File doApply(Packager packager) {
 			VelocityUtils.render(platform + "/assembly.xml.vtl", assemblyFile, packager);
 
 			// zip file name and format
-			String finalName = packager.getZipballName() != null ? packager.getZipballName() : name + "-" + version + "-" + platform;
 			String format = "zip";
 
 			// invokes plugin to assemble zipball and/or tarball
@@ -62,13 +59,23 @@ protected File doApply(Packager packager) {
 							element("outputDirectory", outputDirectory.getAbsolutePath()),
 							element("formats", element("format", format)),
 							element("descriptors", element("descriptor", assemblyFile.getAbsolutePath())),
-							element("finalName", finalName),
 							element("appendAssemblyId", "false")							
 					),
 					Context.getMavenContext().getEnv()
 				);
 
-			return new File(outputDirectory, finalName + "." + format); 
+			// gets generated filename
+			String finalName = Context.getMavenContext().getEnv().getMavenProject().getBuild().getFinalName();
+			File finalFile = new File(outputDirectory, finalName + "." + format);
+
+			// gets desired file name
+			String zipName = packager.getZipballName() != null ? packager.getZipballName() : finalName + "-" + platform;
+			File zipFile = new File(outputDirectory, zipName + "." + format);
+			
+			// rename generated to desired
+			finalFile.renameTo(zipFile);
+			
+			return zipFile;
 
 		} catch (Exception e) {