refactoring

Author: fvarrui

src/main/java/io/github/fvarrui/javapackager/utils/CommandUtils.java

@@ -37,15 +37,14 @@ public static String execute(String executable, List<Object> arguments) throws I
 	public static ExecutionResult executeWithResult(File workingDirectory, String executable, Object... arguments) throws IOException, CommandLineException {
 		ExecutionResult result = new ExecutionResult();
 
-		StringBuffer outputBuffer = new StringBuffer();
-		StringBuffer errorBuffer = new StringBuffer();
+		StringBuilder outputBuffer = new StringBuilder();
+		StringBuilder errorBuffer = new StringBuilder();
 
 		Commandline command = new Commandline();
 		command.setWorkingDirectory(workingDirectory);
 		command.setExecutable(executable);
 		command.createArguments(arguments);
-		command.toString();
-		
+
 		String commandLine = command.getCommandLineAsString();
 
 		Logger.info("Executing command: " + commandLine);
@@ -58,12 +57,12 @@ public static ExecutionResult executeWithResult(File workingDirectory, String ex
 			if (output.ready()) {
 				String outputLine = output.readLine();
 				Logger.info(outputLine);
-				outputBuffer.append(outputLine + "\n");
+				outputBuffer.append(outputLine).append("\n");
 			}
 			if (error.ready()) {
 				String errorLine = error.readLine();
 				Logger.error(errorLine);					
-				errorBuffer.append(errorLine + "\n");
+				errorBuffer.append(errorLine).append("\n");
 			}
 		}
 		output.close();

src/main/java/io/github/fvarrui/javapackager/utils/Commandline.java

@@ -1,6 +1,7 @@
 package io.github.fvarrui.javapackager.utils;
 
 import java.io.File;
+import java.util.Collection;
 
 import org.apache.commons.lang3.StringUtils;
 import org.apache.commons.lang3.SystemUtils;
@@ -28,12 +29,20 @@ public void createArguments(Object... arguments) {
 
 			if (argument == null)
 				continue;
-			
+
+			// expands collections
+			if (argument instanceof Collection) {
+				createArguments(((Collection<?>) argument).toArray(new Object[0]));
+				continue;
+			}
+
+			// expands array
 			if (argument.getClass().isArray()) {
-				createArguments((Object[])argument);
+                createArguments((Object[])argument);
 				continue;
 			}
-			
+
+			// process file argument
 			if (argument instanceof File) {
 
 				File argFile = (File) argument;